Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/blog: inline code blocks with newlines are rendered separately #37972

Closed
tbpg opened this issue Mar 20, 2020 · 2 comments
Closed

x/blog: inline code blocks with newlines are rendered separately #37972

tbpg opened this issue Mar 20, 2020 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@tbpg
Copy link
Contributor

tbpg commented Mar 20, 2020

What did you expect to see?

Code blocks with empty lines should be rendered in a single block. For example, see https://blog.golang.org/using-go-modules are rendered (and the other articles in the series).

What did you see instead?

MJ9JawwmBUo
@gopherbot gopherbot added this to the Unreleased milestone Mar 20, 2020
@gopherbot
Copy link

Change https://golang.org/cl/224958 mentions this issue: present: test Markdown & fix splitting of pre blocks

@andybons andybons added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 23, 2020
@gopherbot
Copy link

Change https://golang.org/cl/224943 mentions this issue: blog: update to latest x/tools for Markdown <pre> fix

gopherbot pushed a commit to golang/blog that referenced this issue Mar 24, 2020
@rsc
blog: update to latest x/tools for Markdown <pre> fix
d69e135 
This fixes <pre> blocks containing blank lines, like in
https://blog.golang.org/v2-go-modules.

Fixes golang/go#37972.

Change-Id: I44adf6ae72f600e19c995a1fde36537d4f06008f
Reviewed-on: https://go-review.googlesource.com/c/blog/+/224943
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
@golang golang locked and limited conversation to collaborators Mar 23, 2021
gopherbot pushed a commit to golang/website that referenced this issue May 26, 2021
@rsc
[x/blog] blog: update to latest x/tools for Markdown <pre> fix
9a05b35 
This fixes <pre> blocks containing blank lines, like in
https://blog.golang.org/v2-go-modules.

Fixes golang/go#37972.

Change-Id: I44adf6ae72f600e19c995a1fde36537d4f06008f
Reviewed-on: https://go-review.googlesource.com/c/blog/+/224943
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
X-Blog-Commit: d69e13551fa530db489dc386e648795a15bc11a9
passionSeven added a commit to passionSeven/website that referenced this issue Oct 18, 2022
@passionSeven
[x/blog] blog: update to latest x/tools for Markdown <pre> fix
e5b596f 
This fixes <pre> blocks containing blank lines, like in
https://blog.golang.org/v2-go-modules.

Fixes golang/go#37972.

Change-Id: I44adf6ae72f600e19c995a1fde36537d4f06008f
Reviewed-on: https://go-review.googlesource.com/c/blog/+/224943
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
X-Blog-Commit: d69e13551fa530db489dc386e648795a15bc11a9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@andybons @gopherbot @tbpg