Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: don't trigger signature help from completion #37966

Closed
stamblerre opened this issue Mar 20, 2020 · 1 comment
Closed

x/tools/gopls: don't trigger signature help from completion #37966

stamblerre opened this issue Mar 20, 2020 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.4.0

Comments

@stamblerre
Copy link
Contributor

See microsoft/vscode-go#3075. This will need a change in gopls to remove the extra command in completions.
@stamblerre stamblerre added this to the gopls/v0.4.0 milestone Mar 20, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Mar 20, 2020
@gopherbot
Copy link

Change https://golang.org/cl/224518 mentions this issue: internal/lsp: remove completion commands

@golang golang locked and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.4.0
Development

No branches or pull requests
2 participants
@stamblerre @gopherbot