x/build/dashboard: atLeastGo1/atMostGo1 helpers handle non-release branches incorrectly #37965
Labels
Builders
x/build issues (builders, bots, dashboards)
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
As a follow-up to #37953, we can improve the
atLeastGo1
andatMostGo1
helpers so that they operate closer to what the name suggests, and report only whether the Go version meets a certain number. Right now they report suboptimal results on non-release branches in some situations.For example, the
master
branch is currently where Go 1.15 is being developed, butatLeastGo1(goBranch, 16)
reports true. It should be false.Similarly,
atMostGo1(goBranch, 15)
makes an incorrect assumption thatmaster
is already greater than 1.15, and reports false. It should be true.cmd/coordinator
can look up precise Go release information (viamaintnerClient
), and use it to make a better decision. We'll need to modify the signature ofBuildsRepoPostSubmit
to pass more information to it./cc @toothrot @cagedmantis
The text was updated successfully, but these errors were encountered: