Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: explain automatic vendoring in 'go help modules' #37930

Closed
jayconrod opened this issue Mar 18, 2020 · 3 comments
Closed

cmd/go: explain automatic vendoring in 'go help modules' #37930

jayconrod opened this issue Mar 18, 2020 · 3 comments
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge modules NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.15

Comments

@jayconrod
Copy link
Contributor

go help modules states that the go command ignores vendor directories in module mode unless the -mod=vendor flag is given. This is not accurate. Since #33848 was implemented in Go 1.14, -mod=vendor may be enabled automatically. We should describe that.

Thanks to @myitcv for pointing this out.

cc @bcmills @matloob
@jayconrod jayconrod added Documentation Issues describing a change to documentation. NeedsFix The path to resolution is known, but the work has not been done. modules labels Mar 18, 2020
@jayconrod jayconrod added this to the Go1.15 milestone Mar 18, 2020
@jayconrod jayconrod self-assigned this Mar 18, 2020
@jayconrod
Copy link
Contributor Author

@gopherbot Please open backport issue for 1.14.

@gopherbot gopherbot mentioned this issue Mar 18, 2020
Closed
@gopherbot
Copy link
Contributor

Backport issue(s) opened: #37931 (for 1.14).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/223926 mentions this issue: cmd/go: update 'go help modules' for automatic vendoring

@golang golang locked and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge modules NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.15
Development

No branches or pull requests
2 participants
@jayconrod @gopherbot