Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: add import / imported by counts #37912

Closed
tooolbox opened this issue Mar 18, 2020 · 2 comments
Closed

x/pkgsite: add import / imported by counts #37912

tooolbox opened this issue Mar 18, 2020 · 2 comments
Labels
FeatureRequest FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite UX Issues that involve UXD/UXR input

Comments

@tooolbox
Copy link

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/CloudyKit/jet

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.122 Safari/537.36

Screenshot

imports

What did you do?

Visited the page.

What did you expect to see?

godoc imports

What did you see instead?

From the main Doc page, you can't see how many imports/imported-by the package has.

One of the useful things about the Godoc pages was at the bottom you could get an instant gauge of how popular or in-use the package was based on the "imported by" count. You could also get an instant gauge of how-many-dependencies-am-i-committing-to-if-i-use-this-package based on the "imports" count. Both of these pieces of data were visible on the page only by scrolling, and if you wanted to know the details you could click through the link.

My suggestion would be to include the count in the tab bar. So, taking the above example, the tab bar entry for imports would say Imports (20) and the imported-by would say Imported By (123). Just to be clear, your tab bar would look like:

Doc | Overview | Subdirectories | Versions | Imports (20) | Imported By (123) | Licenses

I think that it's better to make the info available at a glance rather than now requiring more clicks to see the same thing. Thanks!


...Somewhat off the point but related is that, while the Imported By tab has counts on the page, the Imports tab is divided into Imports and Standard Library Imports with no counts next to them—at least for the package I chose as an example. It would be good to have counts in there.

@gopherbot gopherbot added this to the Unreleased milestone Mar 18, 2020
@julieqiu julieqiu added UX Issues that involve UXD/UXR input FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Mar 18, 2020
@julieqiu
Copy link
Member

Thanks for the detailed feedback! We're currently working with our UX team to add this info, along with addressing other design suggestions. I'll post on this issue once we have any updates.

/cc @fflewddur

@julieqiu julieqiu changed the title go.dev: Add Import/ImportBy Counts x/pkgsite: add import / imported by counts Jun 15, 2020
@julieqiu julieqiu removed the website label Sep 22, 2020
@julieqiu julieqiu removed the website label Sep 22, 2020
@julieqiu
Copy link
Member

This feature is now available on beta.pkg.go.dev. See #41585 (comment) for details.

Closing this issue for #41586.

@golang golang locked and limited conversation to collaborators Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FeatureRequest FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite UX Issues that involve UXD/UXR input
Projects
None yet
Development

No branches or pull requests

3 participants