Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

context: panic when creating an invalid context #37908

Closed
knusbaum opened this issue Mar 18, 2020 · 1 comment
Closed

context: panic when creating an invalid context #37908

knusbaum opened this issue Mar 18, 2020 · 1 comment
Labels
FrozenDueToAge

Comments

@knusbaum
Copy link
Contributor

What version of Go are you using (go version)?

$ go version
go version go1.14 darwin/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/kyle.nusbaum/Library/Caches/go-build"
GOENV="/Users/kyle.nusbaum/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/kyle.nusbaum/Documents/CodeBase/gotree"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.14/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.14/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/kyle.nusbaum/Documents/CodeBase/go/src/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/8x/bn6z9tk109n_hvbhl8fwdmpw0000gn/T/go-build192830994=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

It's possible to create an invalid Context that can propagate through the program and later cause a nil dereference panic when Value is called:
https://play.golang.org/p/zJMpPmKL5M7

One of the trickier things about this is that the context will work as expected until you try to look up a Value that isn't in the context:
https://play.golang.org/p/aLyNCZTeWN8

Because of this and the nature of the Context as a carrier of data, etc. across API boundaries, the source of the bad context and the place where the panic occurs are often in entirely unrelated pieces of code, making tracking down the bug difficult.

What did you expect to see?

WithValue should panic when passed a nil parent context.

What did you see instead?

WithValue returns a Context that can later cause a panic.
@knusbaum knusbaum mentioned this issue Mar 18, 2020
Closed
@gopherbot
Copy link

Change https://golang.org/cl/223777 mentions this issue: context: prevent creation of invalid contexts

@golang golang locked and limited conversation to collaborators Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

context: prevent creation of invalid contexts knusbaum/go-1
2 participants
@knusbaum @gopherbot