Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: TestRemoveAllWithMoreErrorThanReqSize is failing on Plan 9 and Windows [1.13 backport] #37895

Closed
gopherbot opened this issue Mar 17, 2020 · 2 comments
Closed

os: TestRemoveAllWithMoreErrorThanReqSize is failing on Plan 9 and Windows [1.13 backport] #37895

gopherbot opened this issue Mar 17, 2020 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.13.10

Comments

@gopherbot
Copy link

@dmitshur requested issue #35117 to be considered for backport to the next 1.13 minor release.

@gopherbot, please backport to Go 1.13. This is a test fix. It is needed to fix resolve a test failure in the os package on windows-amd64-longtest builder, which could be masking other problems (due to #36181) and making releasing Go 1.13.x more difficult.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 17, 2020
@gopherbot gopherbot mentioned this issue Mar 17, 2020
Closed
@gopherbot gopherbot added this to the Go1.13.9 milestone Mar 17, 2020
@gopherbot
Copy link
Author

Change https://golang.org/cl/223700 mentions this issue: [release-branch.go1.13] os: use an actual RemoveAll failure in TestRemoveAllWithMoreErrorThanReqSize

@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Mar 17, 2020
@cagedmantis cagedmantis modified the milestones: Go1.13.9, Go1.13.10 Mar 19, 2020
@andybons andybons added the CherryPickApproved Used during the release process for point releases label Mar 26, 2020
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 26, 2020
@gopherbot
Copy link
Author

Closed by merging f353662 to release-branch.go1.13.

gopherbot pushed a commit that referenced this issue Mar 31, 2020
@dmitshur
[release-branch.go1.13] os: use an actual RemoveAll failure in TestRe…
f353662 
…moveAllWithMoreErrorThanReqSize

Previously we injected an error, and the injection points were
(empirically) not realistic on some platforms.

Instead, we now make the directory read-only, which (on most
platforms) suffices to prevent the removal of its files.

Also remove unused test hook, as was done in CL 204060.

For #35117.
For #29921.
Fixes #37895.

Change-Id: Ica4e2818566f8c14df3eed7c3b8de5c0abeb6963
Reviewed-on: https://go-review.googlesource.com/c/go/+/203502
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit 06bdd52)
Reviewed-on: https://go-review.googlesource.com/c/go/+/223700
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@golang golang locked and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.13.10
Development

No branches or pull requests
4 participants
@cagedmantis @andybons @dmitshur @gopherbot