Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: clarify details of executeCommand #37893

Closed
stamblerre opened this issue Mar 17, 2020 · 1 comment
Closed

x/tools/gopls: clarify details of executeCommand #37893

stamblerre opened this issue Mar 17, 2020 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.5.0

Comments

@stamblerre
Copy link
Contributor

stamblerre commented Mar 17, 2020 •
edited

Two key things to consider:

  1. Naming convention for commands and constants for tracking these names across the codebase
  2. Making it clear that commands operate only on saved files (if we add commands that handle overlays we can address this, but for now, using snapshots in commands doesn't make a lot of sense)
  3. Explore how the run commands without adding them to the VS Code Go extension
@stamblerre stamblerre added this to the gopls/v0.5.0 milestone Mar 17, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Mar 17, 2020
@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v0.6.0 Apr 2, 2020
@stamblerre stamblerre modified the milestones: gopls/v0.6.0, gopls/v0.5.0 May 21, 2020
@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v1.0.0 Jul 22, 2020
@stamblerre
Copy link
Contributor Author

I believe that all of these questions have been resolved. Naming will be addressed as part of #41187.

@stamblerre stamblerre modified the milestones: gopls/v1.0.0, gopls/v0.5.0 Sep 9, 2020
@golang golang locked and limited conversation to collaborators Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.5.0
Development

No branches or pull requests
2 participants
@stamblerre @gopherbot