Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestCancelRequestWithChannelBeforeDo_Cancel failure on Windows long test [1.13 backport] #37892

Closed
gopherbot opened this issue Mar 16, 2020 · 2 comments
Closed

net/http: TestCancelRequestWithChannelBeforeDo_Cancel failure on Windows long test [1.13 backport] #37892

gopherbot opened this issue Mar 16, 2020 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.13.10

Comments

@gopherbot
Copy link

@dmitshur requested issue #35122 to be considered for backport to the next 1.13 minor release.

@gopherbot, please backport to Go 1.13. This is a test fix. It is needed to fix resolve a failure in the net/http package on windows-amd64-longtest builder, which could be masking other problems and making releasing Go 1.13.x more difficult.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 16, 2020
@gopherbot gopherbot mentioned this issue Mar 16, 2020
Closed
@gopherbot gopherbot added this to the Go1.13.9 milestone Mar 16, 2020
@gopherbot
Copy link
Author

Change https://golang.org/cl/223699 mentions this issue: [release-branch.go1.13] net/http: deflake TestCancelRequestWithChannelBeforeDo_Cancel

@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Mar 17, 2020
@cagedmantis cagedmantis modified the milestones: Go1.13.9, Go1.13.10 Mar 19, 2020
@andybons andybons added the CherryPickApproved Used during the release process for point releases label Mar 26, 2020
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 26, 2020
@gopherbot
Copy link
Author

Closed by merging 7261619 to release-branch.go1.13.

gopherbot pushed a commit that referenced this issue Mar 31, 2020
@iwdgo @dmitshur
[release-branch.go1.13] net/http: deflake TestCancelRequestWithChanne…
7261619 
…lBeforeDo_Cancel

Goroutines clean up takes longer when using deprecated CloseNotifier.

For #35122.
Fixes #37892.

Change-Id: Id820a3012b5c781ddfb294b38ee3b009624e398c
Reviewed-on: https://go-review.googlesource.com/c/go/+/204661
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit 1e4a358)
Reviewed-on: https://go-review.googlesource.com/c/go/+/223699
Run-TryBot: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@golang golang locked and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.13.10
Development

No branches or pull requests
4 participants
@cagedmantis @andybons @dmitshur @gopherbot