Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: clicking a link to an anchor for an example does not show the example #37884

Closed
dcormier opened this issue Mar 16, 2020 · 2 comments
Closed

x/pkgsite: clicking a link to an anchor for an example does not show the example #37884

dcormier opened this issue Mar 16, 2020 · 2 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite Suggested Issues that may be good for new contributors looking for work to do.
Milestone
pkgsite/unplanned

Comments

@dcormier
Copy link
Contributor

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/aws/aws-sdk-go/service/dynamodb/expression?tab=doc#pkg-examples

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:73.0) Gecko/20100101 Firefox/73.0

Screenshot

Clicking this link (bottom of image):

image

Results in the browser going here:

image

What did you do?

I clicked a link in the Examples section.

What did you expect to see?

The example I clicked.

What did you see instead?

I saw the page just below the anchor for the example, with the anchor itself hidden by the page navigation header and not visible at all.
@gopherbot gopherbot added this to the Unreleased milestone Mar 16, 2020
@julieqiu
Copy link
Member

This issue seems to be related to #37520. Also related - #37819.

@julieqiu julieqiu added UX Issues that involve UXD/UXR input NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Mar 17, 2020
@julieqiu julieqiu changed the title go.dev: clicking a link to an anchor for an example does not show the example x/pkgsite: clicking a link to an anchor for an example does not show the example Jun 15, 2020
@julieqiu julieqiu added help wanted NeedsFix The path to resolution is known, but the work has not been done. Suggested Issues that may be good for new contributors looking for work to do. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. UX Issues that involve UXD/UXR input labels Jun 15, 2020
@julieqiu
Copy link
Member

This fix is now live on pkg.go.dev.

@golang golang locked and limited conversation to collaborators Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. pkgsite Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
3 participants
@dcormier @julieqiu @gopherbot