Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: functions with type switches cannot be inlined #37837

Closed
aebrahim opened this issue Mar 13, 2020 · 2 comments
Closed

cmd/compile: functions with type switches cannot be inlined #37837

aebrahim opened this issue Mar 13, 2020 · 2 comments
Labels
FrozenDueToAge help wanted NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. Performance
Milestone
Unplanned

Comments

@aebrahim
Copy link

What version of Go are you using (go version)?

$ go version
go version go1.14 linux/amd64

Does this issue reproduce with the latest release?

N/A 1.14 is the latest release

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"

What did you do?

go build -gcflags="-m -m" demo.go
demo.go.txt

What did you expect to see?

Inlining of small function after #13071

What did you see instead?

./demo.go:15:6: cannot inline SomeFunc: unhandled op TYPESW
@randall77 randall77 added this to the Unplanned milestone Mar 13, 2020
@randall77
Copy link
Contributor

I think we just need to figure out what cost we should assign it.

@toothrot toothrot added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Mar 13, 2020
@gopherbot
Copy link

Change https://golang.org/cl/266203 mentions this issue: cmd/compile: support inlining of type switches

@golang golang locked and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. Performance
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
4 participants
@toothrot @aebrahim @randall77 @gopherbot