Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/syscall/windows/registry: TestWalkFullRegistry failing on windows-amd64-longtest [1.13 backport] #37826

Closed
gopherbot opened this issue Mar 12, 2020 · 3 comments
Closed

internal/syscall/windows/registry: TestWalkFullRegistry failing on windows-amd64-longtest [1.13 backport] #37826

gopherbot opened this issue Mar 12, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.13.9

Comments

@gopherbot
Copy link

@dmitshur requested issue #35084 to be considered for backport to the next 1.13 minor release.

@gopherbot, please backport to Go 1.13. This is a test fix. It is needed to fix resolve a failure on windows-amd64-longtest builder, which could be masking other problems and making releasing Go 1.13.x more difficult.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 12, 2020
@gopherbot gopherbot mentioned this issue Mar 12, 2020
Closed
@gopherbot gopherbot added this to the Go1.13.9 milestone Mar 12, 2020
@gopherbot
Copy link
Author

Change https://golang.org/cl/223237 mentions this issue: [release-branch.go1.13] internal/syscall/windows/registry: remove TestWalkFullRegistry due to false assumptions

@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label Mar 12, 2020
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 12, 2020
@toothrot
Copy link
Contributor

toothrot commented Mar 12, 2020 •
edited by dmitshur

Approving as this is a test fix, and the same fix already been applied in 1.14 and later.

@gopherbot
Copy link
Author

Closed by merging 1a1b02a to release-branch.go1.13.

gopherbot pushed a commit that referenced this issue Mar 12, 2020
@zx2c4 @dmitshur
[release-branch.go1.13] internal/syscall/windows/registry: remove Tes…
1a1b02a 
…tWalkFullRegistry due to false assumptions

This test's existence was predicated upon assumptions about the full
range of known data types and known data into those types. However,
we've learned from Microsoft that there are several undocumented secret
registry types that are in use by various parts of Windows, and we've
learned from inspection that many Microsoft uses of registry types don't
strictly adhere to the recommended value size. It's therefore foolhardy
to make any assumptions about what goes in and out of the registry, and
so this test, as well as its "blacklist", are meaningless.

For #35084.
Fixes #37826.

Change-Id: I6c3fe5fb0e740e88858321b3b042c0ff1a23284e
Reviewed-on: https://go-review.googlesource.com/c/go/+/203604
Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
(cherry picked from commit 0d3092f)
Reviewed-on: https://go-review.googlesource.com/c/go/+/223237
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Mar 17, 2020
@golang golang locked and limited conversation to collaborators Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.13.9
Development

No branches or pull requests
3 participants
@toothrot @dmitshur @gopherbot