-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/pprof: module version suffix shown in graphs instead of package name #37825
Comments
I'm unsure if this should be here or https://github.com/google/pprof (or maybe both). I don't think that there's enough info in the profiles for pprof to actually know it should remove a version suffix. I'll defer that to someone who knows better where the change would need to be made. |
CC @hyangah |
github.com/google/pprof is a better place to discuss visualization and presenting Go's package name. I wished I could transfer this issue but couldn't. @zikaeroh can you open this in the upstream repo? |
Sure, I'll do that. |
Filed google/pprof#515. I'll close this one. |
Meant google/pprof#515, of course. Forgot the repo name. 🙂 |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
Created a profile, and opened it with
go tool pprof
to view a graph of memory allocations.What did you expect to see?
Nodes with package names.
What did you see instead?
Packages which are at the root of a non-v1 module show their version suffix rather than their actual package name, making it more difficult to determine what they are.
For example, jackc's pgx/pgconn, which are at v4 and v2 respectively:
It looks like
pprof
just takes the last element of the import path, which used to be somewhat accurate (ignoring path/package name differences), but is less so now.The text was updated successfully, but these errors were encountered: