Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: module's "go" version should be included in cache key [1.13 backport] #37821

Closed
gopherbot opened this issue Mar 12, 2020 · 3 comments
Closed

cmd/go: module's "go" version should be included in cache key [1.13 backport] #37821

gopherbot opened this issue Mar 12, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.13.9

Comments

@gopherbot
Copy link

@bcmills requested issue #37804 to be considered for backport to the next 1.13 minor release.

@gopherbot, please backport to 1.13 and 1.14: this issue can cause spuriously-successful builds for packages that will not build once published, and there is no workaround for spurious success.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 12, 2020
@gopherbot gopherbot mentioned this issue Mar 12, 2020
Closed
@gopherbot gopherbot added this to the Go1.13.9 milestone Mar 12, 2020
@gopherbot
Copy link
Author

Change https://golang.org/cl/223142 mentions this issue: [release-branch.go1.13] cmd/go: include the go language version in cache keys

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Mar 12, 2020
@dmitshur
Copy link
Contributor

Approving as this is a serious issue without a workaround. The fix is small. /cc @toothrot @cagedmantis

@gopherbot
Copy link
Author

Closed by merging e0f244d to release-branch.go1.13.

gopherbot pushed a commit that referenced this issue Mar 12, 2020
@dmitshur
[release-branch.go1.13] cmd/go: include the go language version in ca…
e0f244d 
…che keys

Fixes #37821
Updates #37804

Change-Id: I4381dc5c58cfd467506d3d73fbd19c2c7257338e
Reviewed-on: https://go-review.googlesource.com/c/go/+/223139
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
(cherry picked from commit c957084)
Reviewed-on: https://go-review.googlesource.com/c/go/+/223142
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@golang golang locked and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.13.9
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot