Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: mlock of signal stack failed: 12 [1.14 backport] #37807

Closed
gopherbot opened this issue Mar 11, 2020 · 5 comments
Closed

runtime: mlock of signal stack failed: 12 [1.14 backport] #37807

gopherbot opened this issue Mar 11, 2020 · 5 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Milestone
Go1.14.1

Comments

@gopherbot
Copy link

@toothrot requested issue #37436 to be considered for backport to the next 1.14 minor release.

@gopherbot please backport to go1.14. It is a serious problem with no workaround.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 11, 2020
@gopherbot gopherbot mentioned this issue Mar 11, 2020
Closed
@gopherbot gopherbot added this to the Go1.14.1 milestone Mar 11, 2020
@toothrot toothrot added release-blocker CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Mar 11, 2020
@toothrot
Copy link
Contributor

Approving as this is a serious problem with no workaround.

@flokli flokli mentioned this issue Mar 12, 2020
Closed
@gopherbot
Copy link
Author

Change https://golang.org/cl/223417 mentions this issue: [release-branch.go1.14]runtime: don't crash on mlock failure

gopherbot pushed a commit that referenced this issue Mar 16, 2020
@ianlancetaylor
[release-branch.go1.14] runtime: don't crash on mlock failure
c512509 
Instead, note that mlock has failed, start trying the mitigation of
touching the signal stack before sending a preemption signal, and,
if the program crashes, mention the possible problem and a wiki page
describing the issue (https://golang.org/wiki/LinuxKernelSignalVectorBug).

Tested on a kernel in the buggy version range, but with the patch,
by using `ulimit -l 0`.

For #37436
Fixes #37807

Change-Id: I072aadb2101496dffd655e442fa5c367dad46ce8
Reviewed-on: https://go-review.googlesource.com/c/go/+/223121
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
(cherry picked from commit b851e51)
Reviewed-on: https://go-review.googlesource.com/c/go/+/223417
TryBot-Result: Gobot Gobot <gobot@golang.org>
@gopherbot
Copy link
Author

Closed by merging c512509 to release-branch.go1.14.

@mrkkrp
Copy link

mrkkrp commented Mar 17, 2020

Sorry for the stupid question, but how downstream users can take advantage of this fix now? Is a new release planned?

@ianlancetaylor
Copy link
Contributor

Yes, we plan to make a 1.14.1 release. It's currently pending on #37833 and #37298.

@flokli flokli mentioned this issue Mar 29, 2020
Merged
10 tasks
flokli added a commit to flokli/nixpkgs that referenced this issue Apr 2, 2020
@flokli
go_1_14: 1.14 -> 1.14.1
da2146d 
This contains at least golang/go#37807, which
currently causes some of our go binaries to just fail when booted with
older kernels.

See golang/go#37436 for context.
Mic92 pushed a commit to NixOS/nixpkgs that referenced this issue Apr 2, 2020
@flokli @Mic92
go_1_14: 1.14 -> 1.14.1
3b38319 
This contains at least golang/go#37807, which
currently causes some of our go binaries to just fail when booted with
older kernels.

See golang/go#37436 for context.

(cherry picked from commit da2146d)
@dani29 dani29 mentioned this issue Apr 18, 2020
Open
@sslavic sslavic mentioned this issue May 1, 2020
Merged
@stealthybox stealthybox mentioned this issue May 5, 2020
Merged
@dcoles dcoles mentioned this issue May 12, 2020
Closed
stigok pushed a commit to stigok/nixpkgs that referenced this issue Jun 12, 2020
@flokli @stigok
go_1_14: 1.14 -> 1.14.1
5865b88 
This contains at least golang/go#37807, which
currently causes some of our go binaries to just fail when booted with
older kernels.

See golang/go#37436 for context.

(cherry picked from commit da2146d)
This was referenced Dec 11, 2020
Closed
Closed
Closed
@golang golang locked and limited conversation to collaborators Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.14.1
Development

No branches or pull requests
4 participants
@toothrot @ianlancetaylor @mrkkrp @gopherbot