Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: searching by smartcontractkit and chainlink does not show github.com/smartcontractkit/chainlink #37801

Open
x448 opened this issue Mar 11, 2020 · 7 comments
Open

x/pkgsite: searching by smartcontractkit and chainlink does not show github.com/smartcontractkit/chainlink #37801

x448 opened this issue Mar 11, 2020 · 7 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/search Issues related to pkg.go.dev search functionality pkgsite
Milestone
pkgsite/search

Comments

@x448
Copy link

x448 commented Mar 11, 2020

There's a fairly active Go project on GitHub that's not found on go.dev so there might be others.

smartcontractkit/chainlink has 6 releases this year, 42 contributors, and 9,372 commits.

image

Just a hunch: could this be related to the project install using git clone instead of go get?

What did you expect to see?

smartcontractkit/chainlink existing on go.dev.

What did you see instead?

smartcontractkit/chainlink is not found in go.dev.
@gopherbot gopherbot added this to the Unreleased milestone Mar 11, 2020
@utrack
Copy link

utrack commented Mar 11, 2020

Are you sure? There it is: https://pkg.go.dev/github.com/smartcontractkit/chainlink?tab=subdirectories

@fsouza
Copy link
Contributor

fsouza commented Mar 11, 2020

OP probably meant the search results: https://pkg.go.dev/search?q=chainlink or https://pkg.go.dev/search?q=smartcontractkit

@julieqiu
Copy link
Member

If this issue is about search results, it seems to be related to supporting fuzzy matching in search. See also #37783 and #36806.

@julieqiu julieqiu mentioned this issue Mar 11, 2020
Closed
@x448
Copy link
Author

x448 commented Mar 11, 2020

Some more info -- in the Versions tab, only 1 entry is shown for smartcontractkit/chainlink:

v0.0.0 (425bc20) – Jan 24, 2019

But they released v0.6.0 - v0.6.10 and v0.7.0 - v0.7.6, so nearly 20 releases are missing.

Also, libraries imported by them in those missing versions don't have them counted as an importer so those other projects are affected indirectly by this.

(click to expand) Screenshot of v0.7.0 - v0.7.6 with release dates

image

I didn't notice anything odd about their release version naming convention.

@julieqiu
Copy link
Member

I believe this is because the module path they put in their go.mod file is chainlink, not github.com/smartcontractkit/chainlink.

image

@julieqiu julieqiu added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 11, 2020
@x448
Copy link
Author

x448 commented Mar 11, 2020

Oh wow, that was freaky, I was on this page about to cut/paste that error from my command line and your screenshot showed up! 👍

@julieqiu
Copy link
Member

Also my comment from #37801 (comment) is inaccurate. This isn't related to fuzzy matching, it is related to searching by subpaths, which we do support. I would have expected these searches to work:

Will investigate.

@julieqiu julieqiu changed the title go.dev: active Go project not found on go.dev (6 releases this year, 42 contributors) go.dev: searching by smartcontractkit/chainlink does not show github.com/smartcontractkit/chainlink Mar 11, 2020
@julieqiu julieqiu changed the title go.dev: searching by smartcontractkit/chainlink does not show github.com/smartcontractkit/chainlink go.dev: searching by smartcontractkit and chainlink does not show github.com/smartcontractkit/chainlink Mar 11, 2020
@julieqiu julieqiu changed the title go.dev: searching by smartcontractkit and chainlink does not show github.com/smartcontractkit/chainlink x/pkgsite: searching by smartcontractkit and chainlink does not show github.com/smartcontractkit/chainlink Jun 15, 2020
@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/search Aug 19, 2020
@julieqiu julieqiu removed the website label Sep 22, 2020
@julieqiu julieqiu removed the website label Sep 22, 2020
@hyangah hyangah added the pkgsite/search Issues related to pkg.go.dev search functionality label May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/search Issues related to pkg.go.dev search functionality pkgsite
Projects
None yet
Milestone
pkgsite/search
Development

No branches or pull requests
6 participants
@fsouza @utrack @hyangah @julieqiu @gopherbot @x448