Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/blake2[b|s]: clarify the difference between the two blake2 packages in the godoc #37784

Closed
katiehockman opened this issue Mar 10, 2020 · 1 comment
Closed

x/crypto/blake2[b|s]: clarify the difference between the two blake2 packages in the godoc #37784

katiehockman opened this issue Mar 10, 2020 · 1 comment
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.15

Comments

@katiehockman
Copy link
Contributor

x/crypto provides two implementations for blake2 hashing: blake2s and blake2b. Looking at the docs, there is no description for why someone should prefer one package over the other.

blake2.net says this:

BLAKE2 comes in two flavors:

  • BLAKE2b (or just BLAKE2) is optimized for 64-bit platforms—including NEON-enabled ARMs—and produces digests of any size between 1 and 64 bytes
  • BLAKE2s is optimized for 8- to 32-bit platforms and produces digests of any size between 1 and 32 bytes

The docs for these two packages should say something similar to inform users when making a choice.

/cc @FiloSottile
@katiehockman katiehockman added Documentation NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Mar 10, 2020
@katiehockman katiehockman added this to the Go1.15 milestone Mar 10, 2020
@katiehockman katiehockman self-assigned this Mar 31, 2020
@gopherbot
Copy link

Change https://golang.org/cl/226845 mentions this issue: blake2b,blake2s: clarify optimizations of each function in docs

@katiehockman katiehockman added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Apr 1, 2020
@golang golang locked and limited conversation to collaborators Apr 3, 2021
mikroskeem pushed a commit to mikroskeem/golang-blake2s that referenced this issue Apr 4, 2021
@katiehockman
blake2b,blake2s: clarify difference between blake2b and blake2s
17ef283 
Fixes golang/go#37784

Change-Id: I2fdaf96979390f3744ba8135da78107a15f5e9a8
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/226845
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 28, 2022
@katiehockman
blake2b,blake2s: clarify difference between blake2b and blake2s
20e0b7c 
Fixes golang/go#37784

Change-Id: I2fdaf96979390f3744ba8135da78107a15f5e9a8
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/226845
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 29, 2022
@katiehockman
blake2b,blake2s: clarify difference between blake2b and blake2s
b5045d4 
Fixes golang/go#37784

Change-Id: I2fdaf96979390f3744ba8135da78107a15f5e9a8
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/226845
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 29, 2022
@katiehockman
blake2b,blake2s: clarify difference between blake2b and blake2s
decb2ca 
Fixes golang/go#37784

Change-Id: I2fdaf96979390f3744ba8135da78107a15f5e9a8
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/226845
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
LewiGoddard pushed a commit to LewiGoddard/crypto that referenced this issue Feb 16, 2023
@katiehockman
blake2b,blake2s: clarify difference between blake2b and blake2s
abd4477 
Fixes golang/go#37784

Change-Id: I2fdaf96979390f3744ba8135da78107a15f5e9a8
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/226845
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
BiiChris pushed a commit to BiiChris/crypto that referenced this issue Sep 15, 2023
@katiehockman
blake2b,blake2s: clarify difference between blake2b and blake2s
daaa44e 
Fixes golang/go#37784

Change-Id: I2fdaf96979390f3744ba8135da78107a15f5e9a8
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/226845
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.15
Development

No branches or pull requests
2 participants
@gopherbot @katiehockman