Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/tls: implement strict TLS 1.3 downgrade protections #37763

Closed
FiloSottile opened this issue Mar 9, 2020 · 2 comments
Closed

crypto/tls: implement strict TLS 1.3 downgrade protections #37763

FiloSottile opened this issue Mar 9, 2020 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.15

Comments

@FiloSottile
Copy link
Contributor

RFC 8446, Section 4.1.3 mandates strict downgrade checks in TLS 1.3. crypto/tls currently sends the downgrade canaries but doesn't check them, because the ecosystem had some off-spec implementations that had to be flushed out.

We should switch the detection on for Go 1.15, on a similar schedule as Chrome. https://groups.google.com/a/chromium.org/d/msg/blink-dev/CK0Xxdz-4Mg/KIOaBAXmBQAJ

This is arguably a risky change, so it should be flagged appropriately.
@FiloSottile FiloSottile added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 9, 2020
@FiloSottile FiloSottile added this to the Go1.15 milestone Mar 9, 2020
@FiloSottile FiloSottile self-assigned this Mar 9, 2020
@OneOfOne
Copy link
Contributor

OneOfOne commented Mar 9, 2020

Just throwing ideas, but IMHO that change should be around a flag of sorts in case someone's server has to deal with broken clients.

@gopherbot
Copy link

Change https://golang.org/cl/231038 mentions this issue: crypto/tls: enforce TLS 1.3 (and TLS 1.2) downgrade protection checks

xujianhai666 pushed a commit to xujianhai666/go-1 that referenced this issue May 21, 2020
@FiloSottile @xujianhai666
crypto/tls: enforce TLS 1.3 (and TLS 1.2) downgrade protection checks
dbe3390 
Fixes golang#37763

Change-Id: Ic6bcc9af0d164966f4ae31087998e5b546540038
Reviewed-on: https://go-review.googlesource.com/c/go/+/231038
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Katie Hockman <katie@golang.org>
@golang golang locked and limited conversation to collaborators May 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.15
Development

No branches or pull requests
3 participants
@OneOfOne @FiloSottile @gopherbot