New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/exp/cmd/gorelease: should not report removal of internal package as incompatible #37756
Comments
/cc @jayconrod |
What was the exact command you ran? (CircleCI links are generally not an appropriate way to report a bug against a tool other than CircleCI itself.) Note that the tool owned by the Go team is |
Sorry for the confusion, I've updated the description. The command run is simply $ gorelease
github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger/genswagger
--------------------------------------------------------------------
Compatible changes:
- package added
github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger
---------------------------------------------------------
Compatible changes:
- package added
github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger
---------------------------------------------------------
Incompatible changes:
- package removed
Inferred base version: v1.14.1
Cannot suggest a release version.
Incompatible changes were detected. |
This comment has been minimized.
This comment has been minimized.
Ok, that's a bug, but it doesn't appear to have anything to do with |
To add some context (if you didn't want to look at the pull request), the actual file changes are just a matter of moving a folder from The error message doesn't make this very clear. In case it makes any difference, the |
Change https://golang.org/cl/224118 mentions this issue: |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
I was using
gorelease
on a library which moved a package frominternal/
to public API.gorelease
was reporting that this was an incompatible change, since a package was removed, but I think this is wrong, since the package wasn't part of the public API beforehand.Apologies if this is a misunderstanding and this does break compatibility.
For more information the error is here: https://app.circleci.com/jobs/github/grpc-ecosystem/grpc-gateway/5755, and the code change is here: grpc-ecosystem/grpc-gateway#1163.
What did you expect to see?
I expected
gorelease
not to report an error.What did you see instead?
I saw an error.
The text was updated successfully, but these errors were encountered: