Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/relnote: look for CLs that had revert CLs sent (but abandoned) #37751

Closed
dmitshur opened this issue Mar 9, 2020 · 3 comments
Closed

x/build/cmd/relnote: look for CLs that had revert CLs sent (but abandoned) #37751

dmitshur opened this issue Mar 9, 2020 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Backlog

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Mar 9, 2020

If a change has a revert CL sent, and later the revert CL gets abandoned, it's likely that the original change is significant enough to be considered for inclusion in release notes. We can detect this fairly easily with maintner's corpus.

For an example where this would've helped, see #29384 (comment). A revert CL was sent, but then abandoned. It could've helped detect that we should include the original CL in the release notes; see #37614.

/cc @cagedmantis @toothrot @ianlancetaylor @mvdan
@dmitshur dmitshur added help wanted Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Mar 9, 2020
@dmitshur dmitshur added this to the Backlog milestone Mar 9, 2020
@dmitshur dmitshur mentioned this issue Mar 9, 2020
Closed
@bcmills
Copy link
Contributor

bcmills commented Mar 9, 2020 •
edited

Maybe? But sometimes the revert is due to a failure in a newly-added test, and is abandoned because the test fix is very simple and applied quickly.

A corresponding issue without the Testing label would probably be a higher-confidence signal, but if we have an open issue about an API change anyway, that should be labeled Documentation and release-blocker if the change is not reverted.

@dmitshur
Copy link
Contributor Author

dmitshur commented Mar 9, 2020

Good points @bcmills. We should be mindful of false-positives this might create.

I was imagining if this is implemented, relnote would emit a new section that humans can review and make decisions on what to keep.

@dmitshur
Copy link
Contributor Author

dmitshur commented Sep 16, 2022 •
edited

I don't recall seeing many other instances where this would've helped, and I suspect the noise to signal ratio would be unfavorable, so this is unlikely to be worth doing. Closing for now.

@dmitshur dmitshur closed this as not planned Won't fix, can't repro, duplicate, stale Sep 16, 2022
@golang golang locked and limited conversation to collaborators Sep 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot