Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/perf: vendor directory is out of sync with go.mod file, govendor tool used to generate it is deprecated #37738

Closed
dmitshur opened this issue Mar 7, 2020 · 5 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Mar 7, 2020

The vendor directory in golang.org/x/perf was last modified 3 years ago and has a vendor.json file. The govendor tool that operates on those files is now deprecated in favor of Go module mode.

The content of the vendor directory doesn't exactly match the versions that are selected in module mode. Using go mod vendor results in a diff that modifies some existing files, and adds many new files:


new file:   vendor/cloud.google.com/go/AUTHORS
new file:   vendor/cloud.google.com/go/CONTRIBUTORS
new file:   vendor/github.com/GoogleCloudPlatform/cloudsql-proxy/CONTRIBUTORS
new file:   vendor/github.com/GoogleCloudPlatform/cloudsql-proxy/LICENSE
new file:   vendor/github.com/GoogleCloudPlatform/cloudsql-proxy/logging/logging.go
new file:   vendor/github.com/GoogleCloudPlatform/cloudsql-proxy/proxy/certs/certs.go
new file:   vendor/github.com/GoogleCloudPlatform/cloudsql-proxy/proxy/dialers/mysql/hook.go
new file:   vendor/github.com/GoogleCloudPlatform/cloudsql-proxy/proxy/proxy/client.go
new file:   vendor/github.com/GoogleCloudPlatform/cloudsql-proxy/proxy/proxy/common.go
new file:   vendor/github.com/GoogleCloudPlatform/cloudsql-proxy/proxy/proxy/dial.go
new file:   vendor/github.com/GoogleCloudPlatform/cloudsql-proxy/proxy/util/cloudsqlutil.go
new file:   vendor/github.com/GoogleCloudPlatform/cloudsql-proxy/proxy/util/gcloudutil.go
new file:   vendor/github.com/aclements/go-gg/ggstat/loess.go
new file:   vendor/github.com/aclements/go-gg/ggstat/lsquares.go
new file:   vendor/github.com/aclements/go-moremath/fit/loess.go
new file:   vendor/github.com/aclements/go-moremath/fit/lsquares.go
new file:   vendor/github.com/aclements/go-moremath/fit/package.go
new file:   vendor/github.com/go-sql-driver/mysql/.gitignore
new file:   vendor/github.com/go-sql-driver/mysql/.travis.yml
new file:   vendor/github.com/go-sql-driver/mysql/AUTHORS
new file:   vendor/github.com/go-sql-driver/mysql/CHANGELOG.md
new file:   vendor/github.com/go-sql-driver/mysql/CONTRIBUTING.md
new file:   vendor/github.com/go-sql-driver/mysql/LICENSE
new file:   vendor/github.com/go-sql-driver/mysql/README.md
new file:   vendor/github.com/go-sql-driver/mysql/appengine.go
new file:   vendor/github.com/go-sql-driver/mysql/auth.go
new file:   vendor/github.com/go-sql-driver/mysql/buffer.go
new file:   vendor/github.com/go-sql-driver/mysql/collations.go
new file:   vendor/github.com/go-sql-driver/mysql/connection.go
new file:   vendor/github.com/go-sql-driver/mysql/connection_go18.go
new file:   vendor/github.com/go-sql-driver/mysql/const.go
new file:   vendor/github.com/go-sql-driver/mysql/driver.go
new file:   vendor/github.com/go-sql-driver/mysql/dsn.go
new file:   vendor/github.com/go-sql-driver/mysql/errors.go
new file:   vendor/github.com/go-sql-driver/mysql/fields.go
new file:   vendor/github.com/go-sql-driver/mysql/infile.go
new file:   vendor/github.com/go-sql-driver/mysql/packets.go
new file:   vendor/github.com/go-sql-driver/mysql/result.go
new file:   vendor/github.com/go-sql-driver/mysql/rows.go
new file:   vendor/github.com/go-sql-driver/mysql/statement.go
new file:   vendor/github.com/go-sql-driver/mysql/transaction.go
new file:   vendor/github.com/go-sql-driver/mysql/utils.go
new file:   vendor/github.com/go-sql-driver/mysql/utils_go17.go
new file:   vendor/github.com/go-sql-driver/mysql/utils_go18.go
new file:   vendor/github.com/golang/protobuf/AUTHORS
new file:   vendor/github.com/golang/protobuf/CONTRIBUTORS
modified:   vendor/github.com/golang/protobuf/LICENSE
deleted:    vendor/github.com/golang/protobuf/proto/Makefile
modified:   vendor/github.com/golang/protobuf/proto/clone.go
modified:   vendor/github.com/golang/protobuf/proto/decode.go
new file:   vendor/github.com/golang/protobuf/proto/discard.go
modified:   vendor/github.com/golang/protobuf/proto/encode.go
modified:   vendor/github.com/golang/protobuf/proto/equal.go
modified:   vendor/github.com/golang/protobuf/proto/extensions.go
modified:   vendor/github.com/golang/protobuf/proto/lib.go
modified:   vendor/github.com/golang/protobuf/proto/message_set.go
new file:   vendor/github.com/golang/protobuf/proto/pointer_reflect.go
modified:   vendor/github.com/golang/protobuf/proto/pointer_unsafe.go
modified:   vendor/github.com/golang/protobuf/proto/properties.go
new file:   vendor/github.com/golang/protobuf/proto/table_marshal.go
new file:   vendor/github.com/golang/protobuf/proto/table_merge.go
new file:   vendor/github.com/golang/protobuf/proto/table_unmarshal.go
modified:   vendor/github.com/golang/protobuf/proto/text.go
modified:   vendor/github.com/golang/protobuf/proto/text_parser.go
new file:   vendor/github.com/gonum/blas/.travis.yml
new file:   vendor/github.com/gonum/blas/README.md
new file:   vendor/github.com/gonum/blas/blas.go
new file:   vendor/github.com/gonum/blas/blas64/blas64.go
new file:   vendor/github.com/gonum/blas/native/dgemm.go
new file:   vendor/github.com/gonum/blas/native/doc.go
new file:   vendor/github.com/gonum/blas/native/general_double.go
new file:   vendor/github.com/gonum/blas/native/general_single.go
new file:   vendor/github.com/gonum/blas/native/internal/math32/math.go
new file:   vendor/github.com/gonum/blas/native/internal/math32/sqrt.go
new file:   vendor/github.com/gonum/blas/native/internal/math32/sqrt_amd64.go
new file:   vendor/github.com/gonum/blas/native/internal/math32/sqrt_amd64.s
new file:   vendor/github.com/gonum/blas/native/level1double.go
new file:   vendor/github.com/gonum/blas/native/level1double_ddot.go
new file:   vendor/github.com/gonum/blas/native/level1single.go
new file:   vendor/github.com/gonum/blas/native/level1single_dsdot.go
new file:   vendor/github.com/gonum/blas/native/level1single_sdot.go
new file:   vendor/github.com/gonum/blas/native/level1single_sdsdot.go
new file:   vendor/github.com/gonum/blas/native/level2double.go
new file:   vendor/github.com/gonum/blas/native/level2single.go
new file:   vendor/github.com/gonum/blas/native/level3double.go
new file:   vendor/github.com/gonum/blas/native/level3single.go
new file:   vendor/github.com/gonum/blas/native/native.go
new file:   vendor/github.com/gonum/blas/native/sgemm.go
new file:   vendor/github.com/gonum/blas/native/single_precision.bash
new file:   vendor/github.com/gonum/floats/.travis.yml
new file:   vendor/github.com/gonum/floats/README.md
new file:   vendor/github.com/gonum/floats/floats.go
new file:   vendor/github.com/gonum/internal/asm/f32/axpyinc_amd64.s
new file:   vendor/github.com/gonum/internal/asm/f32/axpyincto_amd64.s
new file:   vendor/github.com/gonum/internal/asm/f32/axpyunitary_amd64.s
new file:   vendor/github.com/gonum/internal/asm/f32/axpyunitaryto_amd64.s
new file:   vendor/github.com/gonum/internal/asm/f32/ddot.go
new file:   vendor/github.com/gonum/internal/asm/f32/doc.go
new file:   vendor/github.com/gonum/internal/asm/f32/dot.go
new file:   vendor/github.com/gonum/internal/asm/f32/scal.go
new file:   vendor/github.com/gonum/internal/asm/f32/stubs_amd64.go
new file:   vendor/github.com/gonum/internal/asm/f32/stubs_noasm.go
new file:   vendor/github.com/gonum/internal/asm/f64/abssum_amd64.s
new file:   vendor/github.com/gonum/internal/asm/f64/abssuminc_amd64.s
new file:   vendor/github.com/gonum/internal/asm/f64/add_amd64.s
new file:   vendor/github.com/gonum/internal/asm/f64/addconst_amd64.s
new file:   vendor/github.com/gonum/internal/asm/f64/axpy.go
new file:   vendor/github.com/gonum/internal/asm/f64/axpyinc_amd64.s
new file:   vendor/github.com/gonum/internal/asm/f64/axpyincto_amd64.s
new file:   vendor/github.com/gonum/internal/asm/f64/axpyunitary_amd64.s
new file:   vendor/github.com/gonum/internal/asm/f64/axpyunitaryto_amd64.s
new file:   vendor/github.com/gonum/internal/asm/f64/cumprod_amd64.s
new file:   vendor/github.com/gonum/internal/asm/f64/cumsum_amd64.s
new file:   vendor/github.com/gonum/internal/asm/f64/div_amd64.s
new file:   vendor/github.com/gonum/internal/asm/f64/divto_amd64.s
new file:   vendor/github.com/gonum/internal/asm/f64/doc.go
new file:   vendor/github.com/gonum/internal/asm/f64/dot.go
new file:   vendor/github.com/gonum/internal/asm/f64/dot_amd64.s
new file:   vendor/github.com/gonum/internal/asm/f64/l1norm_amd64.s
new file:   vendor/github.com/gonum/internal/asm/f64/linfnorm_amd64.s
new file:   vendor/github.com/gonum/internal/asm/f64/scal.go
new file:   vendor/github.com/gonum/internal/asm/f64/scalinc_amd64.s
new file:   vendor/github.com/gonum/internal/asm/f64/scalincto_amd64.s
new file:   vendor/github.com/gonum/internal/asm/f64/scalunitary_amd64.s
new file:   vendor/github.com/gonum/internal/asm/f64/scalunitaryto_amd64.s
new file:   vendor/github.com/gonum/internal/asm/f64/stubs_amd64.go
new file:   vendor/github.com/gonum/internal/asm/f64/stubs_noasm.go
new file:   vendor/github.com/gonum/lapack/.gitignore
new file:   vendor/github.com/gonum/lapack/.travis.yml
new file:   vendor/github.com/gonum/lapack/README.md
new file:   vendor/github.com/gonum/lapack/lapack.go
new file:   vendor/github.com/gonum/lapack/lapack64/lapack64.go
new file:   vendor/github.com/gonum/lapack/native/dbdsqr.go
new file:   vendor/github.com/gonum/lapack/native/dgebak.go
new file:   vendor/github.com/gonum/lapack/native/dgebal.go
new file:   vendor/github.com/gonum/lapack/native/dgebd2.go
new file:   vendor/github.com/gonum/lapack/native/dgebrd.go
new file:   vendor/github.com/gonum/lapack/native/dgecon.go
new file:   vendor/github.com/gonum/lapack/native/dgeev.go
new file:   vendor/github.com/gonum/lapack/native/dgehd2.go
new file:   vendor/github.com/gonum/lapack/native/dgehrd.go
new file:   vendor/github.com/gonum/lapack/native/dgelq2.go
new file:   vendor/github.com/gonum/lapack/native/dgelqf.go
new file:   vendor/github.com/gonum/lapack/native/dgels.go
new file:   vendor/github.com/gonum/lapack/native/dgeql2.go
new file:   vendor/github.com/gonum/lapack/native/dgeqp3.go
new file:   vendor/github.com/gonum/lapack/native/dgeqr2.go
new file:   vendor/github.com/gonum/lapack/native/dgeqrf.go
new file:   vendor/github.com/gonum/lapack/native/dgerq2.go
new file:   vendor/github.com/gonum/lapack/native/dgerqf.go
new file:   vendor/github.com/gonum/lapack/native/dgesvd.go
new file:   vendor/github.com/gonum/lapack/native/dgetf2.go
new file:   vendor/github.com/gonum/lapack/native/dgetrf.go
new file:   vendor/github.com/gonum/lapack/native/dgetri.go
new file:   vendor/github.com/gonum/lapack/native/dgetrs.go
new file:   vendor/github.com/gonum/lapack/native/dggsvd3.go
new file:   vendor/github.com/gonum/lapack/native/dggsvp3.go
new file:   vendor/github.com/gonum/lapack/native/dhseqr.go
new file:   vendor/github.com/gonum/lapack/native/dlabrd.go
new file:   vendor/github.com/gonum/lapack/native/dlacn2.go
new file:   vendor/github.com/gonum/lapack/native/dlacpy.go
new file:   vendor/github.com/gonum/lapack/native/dlae2.go
new file:   vendor/github.com/gonum/lapack/native/dlaev2.go
new file:   vendor/github.com/gonum/lapack/native/dlaexc.go
new file:   vendor/github.com/gonum/lapack/native/dlags2.go
new file:   vendor/github.com/gonum/lapack/native/dlahqr.go
new file:   vendor/github.com/gonum/lapack/native/dlahr2.go
new file:   vendor/github.com/gonum/lapack/native/dlaln2.go
new file:   vendor/github.com/gonum/lapack/native/dlange.go
new file:   vendor/github.com/gonum/lapack/native/dlanst.go
new file:   vendor/github.com/gonum/lapack/native/dlansy.go
new file:   vendor/github.com/gonum/lapack/native/dlantr.go
new file:   vendor/github.com/gonum/lapack/native/dlanv2.go
new file:   vendor/github.com/gonum/lapack/native/dlapll.go
new file:   vendor/github.com/gonum/lapack/native/dlapmt.go
new file:   vendor/github.com/gonum/lapack/native/dlapy2.go
new file:   vendor/github.com/gonum/lapack/native/dlaqp2.go
new file:   vendor/github.com/gonum/lapack/native/dlaqps.go
new file:   vendor/github.com/gonum/lapack/native/dlaqr04.go
new file:   vendor/github.com/gonum/lapack/native/dlaqr1.go
new file:   vendor/github.com/gonum/lapack/native/dlaqr23.go
new file:   vendor/github.com/gonum/lapack/native/dlaqr5.go
new file:   vendor/github.com/gonum/lapack/native/dlarf.go
new file:   vendor/github.com/gonum/lapack/native/dlarfb.go
new file:   vendor/github.com/gonum/lapack/native/dlarfg.go
new file:   vendor/github.com/gonum/lapack/native/dlarft.go
new file:   vendor/github.com/gonum/lapack/native/dlarfx.go
new file:   vendor/github.com/gonum/lapack/native/dlartg.go
new file:   vendor/github.com/gonum/lapack/native/dlas2.go
new file:   vendor/github.com/gonum/lapack/native/dlascl.go
new file:   vendor/github.com/gonum/lapack/native/dlaset.go
new file:   vendor/github.com/gonum/lapack/native/dlasq1.go
new file:   vendor/github.com/gonum/lapack/native/dlasq2.go
new file:   vendor/github.com/gonum/lapack/native/dlasq3.go
new file:   vendor/github.com/gonum/lapack/native/dlasq4.go
new file:   vendor/github.com/gonum/lapack/native/dlasq5.go
new file:   vendor/github.com/gonum/lapack/native/dlasq6.go
new file:   vendor/github.com/gonum/lapack/native/dlasr.go
new file:   vendor/github.com/gonum/lapack/native/dlasrt.go
new file:   vendor/github.com/gonum/lapack/native/dlassq.go
new file:   vendor/github.com/gonum/lapack/native/dlasv2.go
new file:   vendor/github.com/gonum/lapack/native/dlaswp.go
new file:   vendor/github.com/gonum/lapack/native/dlasy2.go
new file:   vendor/github.com/gonum/lapack/native/dlatrd.go
new file:   vendor/github.com/gonum/lapack/native/dlatrs.go
new file:   vendor/github.com/gonum/lapack/native/doc.go
new file:   vendor/github.com/gonum/lapack/native/dorg2l.go
new file:   vendor/github.com/gonum/lapack/native/dorg2r.go
new file:   vendor/github.com/gonum/lapack/native/dorgbr.go
new file:   vendor/github.com/gonum/lapack/native/dorghr.go
new file:   vendor/github.com/gonum/lapack/native/dorgl2.go
new file:   vendor/github.com/gonum/lapack/native/dorglq.go
new file:   vendor/github.com/gonum/lapack/native/dorgql.go
new file:   vendor/github.com/gonum/lapack/native/dorgqr.go
new file:   vendor/github.com/gonum/lapack/native/dorgtr.go
new file:   vendor/github.com/gonum/lapack/native/dorm2r.go
new file:   vendor/github.com/gonum/lapack/native/dormbr.go
new file:   vendor/github.com/gonum/lapack/native/dormhr.go
new file:   vendor/github.com/gonum/lapack/native/dorml2.go
new file:   vendor/github.com/gonum/lapack/native/dormlq.go
new file:   vendor/github.com/gonum/lapack/native/dormqr.go
new file:   vendor/github.com/gonum/lapack/native/dormr2.go
new file:   vendor/github.com/gonum/lapack/native/dpocon.go
new file:   vendor/github.com/gonum/lapack/native/dpotf2.go
new file:   vendor/github.com/gonum/lapack/native/dpotrf.go
new file:   vendor/github.com/gonum/lapack/native/drscl.go
new file:   vendor/github.com/gonum/lapack/native/dsteqr.go
new file:   vendor/github.com/gonum/lapack/native/dsterf.go
new file:   vendor/github.com/gonum/lapack/native/dsyev.go
new file:   vendor/github.com/gonum/lapack/native/dsytd2.go
new file:   vendor/github.com/gonum/lapack/native/dsytrd.go
new file:   vendor/github.com/gonum/lapack/native/dtgsja.go
new file:   vendor/github.com/gonum/lapack/native/dtrcon.go
new file:   vendor/github.com/gonum/lapack/native/dtrevc3.go
new file:   vendor/github.com/gonum/lapack/native/dtrexc.go
new file:   vendor/github.com/gonum/lapack/native/dtrti2.go
new file:   vendor/github.com/gonum/lapack/native/dtrtri.go
new file:   vendor/github.com/gonum/lapack/native/dtrtrs.go
new file:   vendor/github.com/gonum/lapack/native/general.go
new file:   vendor/github.com/gonum/lapack/native/iladlc.go
new file:   vendor/github.com/gonum/lapack/native/iladlr.go
new file:   vendor/github.com/gonum/lapack/native/ilaenv.go
new file:   vendor/github.com/gonum/lapack/native/iparmq.go
new file:   vendor/github.com/gonum/matrix/.travis.yml
new file:   vendor/github.com/gonum/matrix/README.md
new file:   vendor/github.com/gonum/matrix/consts.go
new file:   vendor/github.com/gonum/matrix/doc.go
new file:   vendor/github.com/gonum/matrix/errors.go
new file:   vendor/github.com/gonum/matrix/generate.go
new file:   vendor/github.com/gonum/matrix/mat64/cholesky.go
new file:   vendor/github.com/gonum/matrix/mat64/dense.go
new file:   vendor/github.com/gonum/matrix/mat64/dense_arithmetic.go
new file:   vendor/github.com/gonum/matrix/mat64/doc.go
new file:   vendor/github.com/gonum/matrix/mat64/eigen.go
new file:   vendor/github.com/gonum/matrix/mat64/format.go
new file:   vendor/github.com/gonum/matrix/mat64/gsvd.go
new file:   vendor/github.com/gonum/matrix/mat64/hogsvd.go
new file:   vendor/github.com/gonum/matrix/mat64/index_bound_checks.go
new file:   vendor/github.com/gonum/matrix/mat64/index_no_bound_checks.go
new file:   vendor/github.com/gonum/matrix/mat64/inner.go
new file:   vendor/github.com/gonum/matrix/mat64/io.go
new file:   vendor/github.com/gonum/matrix/mat64/lq.go
new file:   vendor/github.com/gonum/matrix/mat64/lu.go
new file:   vendor/github.com/gonum/matrix/mat64/matrix.go
new file:   vendor/github.com/gonum/matrix/mat64/offset.go
new file:   vendor/github.com/gonum/matrix/mat64/offset_appengine.go
new file:   vendor/github.com/gonum/matrix/mat64/pool.go
new file:   vendor/github.com/gonum/matrix/mat64/product.go
new file:   vendor/github.com/gonum/matrix/mat64/qr.go
new file:   vendor/github.com/gonum/matrix/mat64/shadow.go
new file:   vendor/github.com/gonum/matrix/mat64/solve.go
new file:   vendor/github.com/gonum/matrix/mat64/svd.go
new file:   vendor/github.com/gonum/matrix/mat64/symmetric.go
new file:   vendor/github.com/gonum/matrix/mat64/triangular.go
new file:   vendor/github.com/gonum/matrix/mat64/vector.go
new file:   vendor/github.com/googleapis/gax-go/.gitignore
new file:   vendor/github.com/googleapis/gax-go/.travis.yml
new file:   vendor/github.com/mattn/go-sqlite3/.gitignore
new file:   vendor/github.com/mattn/go-sqlite3/.travis.yml
new file:   vendor/golang.org/x/net/AUTHORS
new file:   vendor/golang.org/x/net/CONTRIBUTORS
new file:   vendor/golang.org/x/net/LICENSE
new file:   vendor/golang.org/x/net/PATENTS
new file:   vendor/golang.org/x/net/context/context.go
new file:   vendor/golang.org/x/net/context/ctxhttp/ctxhttp.go
new file:   vendor/golang.org/x/net/context/go17.go
new file:   vendor/golang.org/x/net/context/go19.go
new file:   vendor/golang.org/x/net/context/pre_go17.go
new file:   vendor/golang.org/x/net/context/pre_go19.go
new file:   vendor/golang.org/x/net/http/httpguts/guts.go
new file:   vendor/golang.org/x/net/http/httpguts/httplex.go
new file:   vendor/golang.org/x/net/http2/.gitignore
new file:   vendor/golang.org/x/net/http2/Dockerfile
new file:   vendor/golang.org/x/net/http2/Makefile
new file:   vendor/golang.org/x/net/http2/README
new file:   vendor/golang.org/x/net/http2/ciphers.go
new file:   vendor/golang.org/x/net/http2/client_conn_pool.go
new file:   vendor/golang.org/x/net/http2/databuffer.go
new file:   vendor/golang.org/x/net/http2/errors.go
new file:   vendor/golang.org/x/net/http2/flow.go
new file:   vendor/golang.org/x/net/http2/frame.go
new file:   vendor/golang.org/x/net/http2/go111.go
new file:   vendor/golang.org/x/net/http2/gotrack.go
new file:   vendor/golang.org/x/net/http2/headermap.go
new file:   vendor/golang.org/x/net/http2/hpack/encode.go
new file:   vendor/golang.org/x/net/http2/hpack/hpack.go
new file:   vendor/golang.org/x/net/http2/hpack/huffman.go
new file:   vendor/golang.org/x/net/http2/hpack/tables.go
new file:   vendor/golang.org/x/net/http2/http2.go
new file:   vendor/golang.org/x/net/http2/not_go111.go
new file:   vendor/golang.org/x/net/http2/pipe.go
new file:   vendor/golang.org/x/net/http2/server.go
new file:   vendor/golang.org/x/net/http2/transport.go
new file:   vendor/golang.org/x/net/http2/write.go
new file:   vendor/golang.org/x/net/http2/writesched.go
new file:   vendor/golang.org/x/net/http2/writesched_priority.go
new file:   vendor/golang.org/x/net/http2/writesched_random.go
new file:   vendor/golang.org/x/net/idna/idna.go
new file:   vendor/golang.org/x/net/idna/punycode.go
new file:   vendor/golang.org/x/net/idna/tables.go
new file:   vendor/golang.org/x/net/idna/trie.go
new file:   vendor/golang.org/x/net/idna/trieval.go
new file:   vendor/golang.org/x/net/internal/timeseries/timeseries.go
new file:   vendor/golang.org/x/net/trace/events.go
new file:   vendor/golang.org/x/net/trace/histogram.go
new file:   vendor/golang.org/x/net/trace/trace.go
new file:   vendor/golang.org/x/oauth2/.travis.yml
new file:   vendor/golang.org/x/oauth2/client_appengine.go
new file:   vendor/golang.org/x/oauth2/google/appengine_hook.go
new file:   vendor/golang.org/x/oauth2/google/appenginevm_hook.go
new file:   vendor/golang.org/x/text/AUTHORS
new file:   vendor/golang.org/x/text/CONTRIBUTORS
new file:   vendor/golang.org/x/text/LICENSE
new file:   vendor/golang.org/x/text/PATENTS
new file:   vendor/golang.org/x/text/secure/bidirule/bidirule.go
new file:   vendor/golang.org/x/text/secure/bidirule/bidirule10.0.0.go
new file:   vendor/golang.org/x/text/secure/bidirule/bidirule9.0.0.go
new file:   vendor/golang.org/x/text/transform/transform.go
new file:   vendor/golang.org/x/text/unicode/bidi/bidi.go
new file:   vendor/golang.org/x/text/unicode/bidi/bracket.go
new file:   vendor/golang.org/x/text/unicode/bidi/core.go
new file:   vendor/golang.org/x/text/unicode/bidi/prop.go
new file:   vendor/golang.org/x/text/unicode/bidi/tables10.0.0.go
new file:   vendor/golang.org/x/text/unicode/bidi/tables9.0.0.go
new file:   vendor/golang.org/x/text/unicode/bidi/trieval.go
new file:   vendor/golang.org/x/text/unicode/norm/composition.go
new file:   vendor/golang.org/x/text/unicode/norm/forminfo.go
new file:   vendor/golang.org/x/text/unicode/norm/input.go
new file:   vendor/golang.org/x/text/unicode/norm/iter.go
new file:   vendor/golang.org/x/text/unicode/norm/normalize.go
new file:   vendor/golang.org/x/text/unicode/norm/readwriter.go
new file:   vendor/golang.org/x/text/unicode/norm/tables10.0.0.go
new file:   vendor/golang.org/x/text/unicode/norm/tables9.0.0.go
new file:   vendor/golang.org/x/text/unicode/norm/transform.go
new file:   vendor/golang.org/x/text/unicode/norm/trie.go
new file:   vendor/google.golang.org/api/AUTHORS
new file:   vendor/google.golang.org/api/CONTRIBUTORS
new file:   vendor/google.golang.org/api/oauth2/v2/oauth2-api.json
new file:   vendor/google.golang.org/api/oauth2/v2/oauth2-gen.go
new file:   vendor/google.golang.org/api/sqladmin/v1beta4/sqladmin-api.json
new file:   vendor/google.golang.org/api/sqladmin/v1beta4/sqladmin-gen.go
new file:   vendor/google.golang.org/api/transport/dial_appengine.go
new file:   vendor/google.golang.org/appengine/.travis.yml
new file:   vendor/google.golang.org/appengine/CONTRIBUTING.md
new file:   vendor/google.golang.org/appengine/LICENSE
new file:   vendor/google.golang.org/appengine/README.md
new file:   vendor/google.golang.org/appengine/appengine.go
new file:   vendor/google.golang.org/appengine/appengine_vm.go
new file:   vendor/google.golang.org/appengine/cloudsql/cloudsql.go
new file:   vendor/google.golang.org/appengine/cloudsql/cloudsql_classic.go
new file:   vendor/google.golang.org/appengine/cloudsql/cloudsql_vm.go
new file:   vendor/google.golang.org/appengine/errors.go
new file:   vendor/google.golang.org/appengine/go.mod
new file:   vendor/google.golang.org/appengine/go.sum
new file:   vendor/google.golang.org/appengine/identity.go
new file:   vendor/google.golang.org/appengine/internal/api.go
new file:   vendor/google.golang.org/appengine/internal/api_classic.go
new file:   vendor/google.golang.org/appengine/internal/api_common.go
new file:   vendor/google.golang.org/appengine/internal/app_id.go
new file:   vendor/google.golang.org/appengine/internal/app_identity/app_identity_service.pb.go
new file:   vendor/google.golang.org/appengine/internal/app_identity/app_identity_service.proto
new file:   vendor/google.golang.org/appengine/internal/base/api_base.pb.go
new file:   vendor/google.golang.org/appengine/internal/base/api_base.proto
new file:   vendor/google.golang.org/appengine/internal/datastore/datastore_v3.pb.go
new file:   vendor/google.golang.org/appengine/internal/datastore/datastore_v3.proto
new file:   vendor/google.golang.org/appengine/internal/identity.go
new file:   vendor/google.golang.org/appengine/internal/identity_classic.go
new file:   vendor/google.golang.org/appengine/internal/identity_flex.go
new file:   vendor/google.golang.org/appengine/internal/identity_vm.go
new file:   vendor/google.golang.org/appengine/internal/internal.go
new file:   vendor/google.golang.org/appengine/internal/log/log_service.pb.go
new file:   vendor/google.golang.org/appengine/internal/log/log_service.proto
new file:   vendor/google.golang.org/appengine/internal/main.go
new file:   vendor/google.golang.org/appengine/internal/main_common.go
new file:   vendor/google.golang.org/appengine/internal/main_vm.go
new file:   vendor/google.golang.org/appengine/internal/metadata.go
new file:   vendor/google.golang.org/appengine/internal/modules/modules_service.pb.go
new file:   vendor/google.golang.org/appengine/internal/modules/modules_service.proto
new file:   vendor/google.golang.org/appengine/internal/net.go
new file:   vendor/google.golang.org/appengine/internal/regen.sh
new file:   vendor/google.golang.org/appengine/internal/remote_api/remote_api.pb.go
new file:   vendor/google.golang.org/appengine/internal/remote_api/remote_api.proto
new file:   vendor/google.golang.org/appengine/internal/socket/socket_service.pb.go
new file:   vendor/google.golang.org/appengine/internal/socket/socket_service.proto
new file:   vendor/google.golang.org/appengine/internal/transaction.go
new file:   vendor/google.golang.org/appengine/internal/urlfetch/urlfetch_service.pb.go
new file:   vendor/google.golang.org/appengine/internal/urlfetch/urlfetch_service.proto
new file:   vendor/google.golang.org/appengine/internal/user/user_service.pb.go
new file:   vendor/google.golang.org/appengine/internal/user/user_service.proto
new file:   vendor/google.golang.org/appengine/log/api.go
new file:   vendor/google.golang.org/appengine/log/log.go
new file:   vendor/google.golang.org/appengine/namespace.go
new file:   vendor/google.golang.org/appengine/socket/doc.go
new file:   vendor/google.golang.org/appengine/socket/socket_classic.go
new file:   vendor/google.golang.org/appengine/socket/socket_vm.go
new file:   vendor/google.golang.org/appengine/timeout.go
new file:   vendor/google.golang.org/appengine/travis_install.sh
new file:   vendor/google.golang.org/appengine/travis_test.sh
new file:   vendor/google.golang.org/appengine/urlfetch/urlfetch.go
new file:   vendor/google.golang.org/appengine/user/oauth.go
new file:   vendor/google.golang.org/appengine/user/user.go
new file:   vendor/google.golang.org/appengine/user/user_classic.go
new file:   vendor/google.golang.org/appengine/user/user_vm.go
new file:   vendor/google.golang.org/grpc/.travis.yml
modified:   vendor/google.golang.org/grpc/codegen.sh
modified:   vendor/google.golang.org/grpc/coverage.sh
new file:   vendor/modules.txt
deleted:    vendor/vendor.json

The vendor directory may or may not used depending on many factors, including the version of Go used, flags used, whether automatic vendoring (#33848) is on, and so on. This makes builds in this repository more unpredictable.

It would be nice to resolve this difference in some way. Given that govendor is deprecated, we should not continue to rely on it. I see two possible solutions:

  1. Use go mod vendor to generate vendor. This will add many more files to the repository.
  2. Remove the vendor directory and rely on go.mod file. This is my current preference.
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 7, 2020
@dmitshur dmitshur added this to the Unreleased milestone Mar 7, 2020
@gopherbot
Copy link

Change https://golang.org/cl/222540 mentions this issue: vendor: delete

@bcmills
Copy link
Contributor

bcmills commented May 15, 2020

Given the lack of traffic on this issue, I'd say we should just remove the vendor directory.

@dmitshur
Copy link
Contributor Author

@bcmills I'm in agreement. I'll update the commit message of CL 222540 and add a reviewer to it.

@dmitshur dmitshur self-assigned this May 15, 2020
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 15, 2020
@cherrymui
Copy link
Member

cc @aclements @dr2chase @rsc , who I think know better about this repo.

@dmitshur
Copy link
Contributor Author

Submitting this now as I believe it's safe, the newly selected versions are functional. If this does cause some issue, please ping me and I'll look into it.

@golang golang locked and limited conversation to collaborators Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

4 participants