x/build/cmd/gerritbot: gerritChangeRE doesn't match Gerrit repository names with dashes #37725
Labels
Builders
x/build issues (builders, bots, dashboards)
FrozenDueToAge
NeedsFix
The path to resolution is known, but the work has not been done.
Milestone
The regexp currently uses
\w+
to match a Gerrit repository name. That expands to:Dashes aren't a part of
\w
, so a Gerrit repository with a dash won't get recognized, andgerritbot
won't be able to post comments when importing PRs from it.This is affecting the new
vscode-go
repository, but also some existing ones (sublime-config
,grpc-review
, etc.).The fix is trivial, just update the regexp to also accept a dash character. I'll also add a test that any future repository names are matched too.
/cc @cagedmantis @toothrot @hyangah @stamblerre
The text was updated successfully, but these errors were encountered: