Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: support multi-project workspaces #37720

Closed
heschi opened this issue Mar 6, 2020 · 4 comments
Closed

x/tools/gopls: support multi-project workspaces #37720

heschi opened this issue Mar 6, 2020 · 4 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.

Comments

@heschi
Copy link
Contributor

heschi commented Mar 6, 2020

This is a place to discuss multi-project workspaces in gopls. Design doc forthcoming.
@gopherbot gopherbot added this to the Unreleased milestone Mar 6, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Mar 6, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v1.0.0 Mar 9, 2020
@stamblerre stamblerre mentioned this issue Mar 11, 2020
Closed
@stamblerre stamblerre modified the milestones: gopls/v1.0.0, gopls/v0.5.0 Mar 12, 2020
@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v0.6.0 Apr 2, 2020
@heschi
Copy link
Contributor Author

heschi commented Jun 8, 2020

Apparently I never actually attached the design doc. It's here: https://github.com/golang/proposal/blob/master/design/37720-gopls-workspaces.md

@stamblerre stamblerre modified the milestones: gopls/v0.6.0, gopls/v0.5.0 Jun 26, 2020
@hyangah
Copy link
Contributor

hyangah commented Jun 28, 2020

What I am concerned about is the proposed super-module may cause what gopls sees to be different from what other tools (the go command, debugger, etc) integrated to the editors outside gopls will see. That can be a source of confusion potentially. If we take this path, I think we need a way to make the go command and other tool to use the same approach and provide consistent views.

@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v1.0.0 Jul 22, 2020
@stamblerre stamblerre mentioned this issue Aug 26, 2020
Closed
@stamblerre
Copy link
Contributor

De-duping this with #32394, as that issue has been more popular.

@stamblerre
Copy link
Contributor

Duplicate of #32394

@stamblerre stamblerre marked this as a duplicate of #32394 Sep 9, 2020
@stamblerre stamblerre removed this from the gopls/v1.0.0 milestone Sep 9, 2020
@hyangah hyangah mentioned this issue Sep 9, 2020
Closed
@golang golang locked and limited conversation to collaborators Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hyangah @stamblerre @gopherbot @heschi