New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: asyncPreempt should not try to save floating-point context for softfloat MIPS targets #37653
Comments
Thanks for catching this! I'll send a fix. |
Change https://golang.org/cl/222057 mentions this issue: |
We probably want to backport this to Go 1.14, otherwise it will SIGILL on softfloat MIPS machines. @gopherbot please backport this to Go 1.14. Thanks. |
Backport issue(s) opened: #37667 (for 1.14). Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases. |
Change https://golang.org/cl/222062 mentions this issue: |
…oftfloat mode on MIPS(64) Fixes #37667. Updates #37653. Change-Id: I6188e44b4bc4aba7b56f29d9ce9de4618c70fd7b Reviewed-on: https://go-review.googlesource.com/c/go/+/222057 Run-TryBot: Cherry Zhang <cherryyz@google.com> Reviewed-by: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> (cherry picked from commit 588ee79) Reviewed-on: https://go-review.googlesource.com/c/go/+/222062
The GOMIPS_softfloat and GOMIPS64_softfloat defines can be used to conditionally compile floating-point context save/restore. It would be nice if assembler would error out when trying to use FP registers when targeting softfloat. Currently we silently end up with floating-point instructions in softfloat binaries.
go/src/runtime/preempt_mips64x.s
Lines 40 to 45 in cd9fd64
go/src/runtime/preempt_mipsx.s
Lines 40 to 45 in cd9fd64
@randall77
@cherrymui
@vstefanovic
The text was updated successfully, but these errors were encountered: