Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: mod init has no version warnings #37635

Closed
terinjokes opened this issue Mar 3, 2020 · 1 comment
Closed

cmd/go: mod init has no version warnings #37635

terinjokes opened this issue Mar 3, 2020 · 1 comment
Labels
FrozenDueToAge GoCommand cmd/go modules
Milestone
Backlog

Comments

@terinjokes
Copy link
Contributor

What version of Go are you using (go version)?

go version go1.14 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/terin/.cache/go-build"
GOENV="/home/terin/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/terin/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/tmp/go-mod-init-demo/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build298501176=/tmp/go-build -gno-record-gcc-switches"

What did you do?

I create a git repository where the latest tag is >= v2, then ran go mod init

$ git init

$ git commit --allow-empty -m "2.10.0: example release"

$ git remote add origin https://github.com/terinjokes/go-mod-init-demo.git

$ git tag -s v2.10.0

$ git describe
v2.10.0

What did you expect to see?

A warning the the import path may be incompatible with Go modules. For example:

$ go mod init github.com/terinjokes/go-mod-init-demo
go: warning latest tag is v2.1.0, but module not have a /v2 path. This may prevent others from importing your module.
go: creating new go.mod: module github.com/terinjokes/go-mod-init-demo

The phrasing is just for an example. I recognize there may be several edge cases in accurately detecting the scenarios and intents of users, but I've seen many projects migrate from vendoring while already at a >= v2 release, and not realize they've made their project difficult to import.

What did you see instead?

$ go mod init github.com/terinjokes/go-mod-init-demo
go: creating new go.mod: module github.com/terinjokes/go-mod-init-demo
@terinjokes terinjokes changed the title cmd/go: mod init provides not version warnings cmd/go: mod init has no version warnings Mar 3, 2020
@dmitshur dmitshur added this to the Backlog milestone Mar 3, 2020
@bcmills
Copy link
Contributor

bcmills commented Mar 3, 2020

Duplicate of #31549

@bcmills bcmills marked this as a duplicate of #31549 Mar 3, 2020
@bcmills bcmills closed this as completed Mar 3, 2020
@golang golang locked and limited conversation to collaborators Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge GoCommand cmd/go modules
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@terinjokes @dmitshur @bcmills @gopherbot