Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/playground: deploy using current Go version #37632

Closed
dmitshur opened this issue Mar 3, 2020 · 3 comments
Closed

x/playground: deploy using current Go version #37632

dmitshur opened this issue Mar 3, 2020 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Mar 3, 2020

https://play.golang.org/p/Ztyu2FJaajl currently prints go1.13.7. It should be a newer Go release such as go1.13.8 or go1.14.

Playground deployments were automated in issue #32606.

I couldn't find an existing issue about this, so filing this one.

/cc @toothrot @cagedmantis
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 3, 2020
@dmitshur dmitshur modified the milestones: Backlog, Unreleased Mar 3, 2020
@dmitshur dmitshur mentioned this issue Mar 5, 2020
Closed
@smasher164
Copy link
Member

smasher164 commented Mar 15, 2020 •
edited

AFAIK, since Go 1.14 dropped GOOS=nacl, #25224 intends to use gVisor for sandboxing on the playground. Judging by #25224 (comment),

It hasn't been load tested or monitored or productionized (health check configs) quite enough yet probably.

Since 1.14 hasn't been deployed yet, this is likely why commit golang/playground@09dfaa1 failed to deploy.

@andybons
Copy link
Member

@smasher164 that’s correct. Output from the build log:

Step #1: go/test/zerodivide.go
Step #1: Removing intermediate container 1e991cbe64ff
Step #1:  ---> f5f8c406a970
Step #1: Step 21/68 : RUN git clone --depth=1 --branch=$GO_VERSION https://go.googlesource.com/go /usr/local/go
Step #1:  ---> Running in 13464d5d2707
Step #1: �[91mCloning into '/usr/local/go'...
Step #1: �[0m�[91mNote: checking out '564c76a268b75f56d6f465b82fba7f6fb929fd70'.
Step #1: 
Step #1: You are in 'detached HEAD' state. You can look around, make experimental
Step #1: changes and commit them, and you can discard any commits you make in this
Step #1: state without impacting any branches by performing another checkout.
Step #1: 
Step #1: If you want to create a new branch to retain commits you create, you may
Step #1: do so (now or later) by using -b with the checkout command again. Example:
Step #1: 
Step #1:   git checkout -b <new-branch-name>
Step #1: 
Step #1: �[0mRemoving intermediate container 13464d5d2707
Step #1:  ---> e865f4038f18
Step #1: Step 22/68 : RUN patch /usr/local/go/src/runtime/rt0_nacl_amd64p32.s /usr/local/playground/enable-fake-time.patch
Step #1:  ---> Running in aab9c54b6e5c
Step #1: �[91mpatch: **** Can't reopen file /usr/local/go/src/runtime/rt0_nacl_amd64p32.s : No such file or directory
Step #1: �[0mpatching file /usr/local/go/src/runtime/rt0_nacl_amd64p32.s
Step #1: Hunk #1 FAILED at 25.
Step #1: The command '/bin/sh -c patch /usr/local/go/src/runtime/rt0_nacl_amd64p32.s /usr/local/playground/enable-fake-time.patch' returned a non-zero code: 2
Finished Step #1
ERROR
ERROR: build step 1 "gcr.io/cloud-builders/docker" failed: step exited with non-zero status: 2

@dmitshur
Copy link
Contributor Author

https://play.golang.org/p/Ztyu2FJaajl reports 1.14.3, which is the latest Go release. Closing as resolved.

Thanks to everyone who contributed to resolving this issue.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 18, 2020
@golang golang locked and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@andybons @dmitshur @gopherbot @smasher164