Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: Go 1.14.rc1 3-5% performance regression from 1.13 during protobuf marshalling [1.14 backport] #37613

Closed
dmitshur opened this issue Mar 2, 2020 · 4 comments
Closed

runtime: Go 1.14.rc1 3-5% performance regression from 1.13 during protobuf marshalling [1.14 backport] #37613

dmitshur opened this issue Mar 2, 2020 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.14.1

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Mar 2, 2020 •
edited

@randall77 requested issue #37086 to be considered for backport to the next 1.14 minor release.

@gopherbot ple​ase open a backport issue.

I don't think this performance regression qualifies for a backport, but I'll let the release guys make that call.
@dmitshur dmitshur added the CherryPickCandidate Used during the release process for point releases label Mar 2, 2020
@dmitshur dmitshur added this to the Go1.14.1 milestone Mar 2, 2020
@dmitshur dmitshur changed the title runtime: golang 1.14.rc1 3-5% performance regression from golang 1.13 during protobuf marshalling [1.13 backport] runtime: golang 1.14.rc1 3-5% performance regression from golang 1.13 during protobuf marshalling [1.14 backport] Mar 2, 2020
This was referenced Mar 2, 2020
Closed
Closed
@randall77
Copy link
Contributor

Turns out we need to backport this patch anyway to fix #37721 .
So it's not just a performance thing.

@gopherbot
Copy link

Change https://golang.org/cl/222779 mentions this issue: [release-branch.go1.14] runtime: special case interface hashing for pointers

@dmitshur
Copy link
Contributor Author

Approved as this is a regression in 1.14 only and has no workaround, and is needed to backport a fix for a serious issue #37721.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Mar 10, 2020
@gopherbot
Copy link

Closed by merging 6717d27 to release-branch.go1.14.

gopherbot pushed a commit that referenced this issue Mar 10, 2020
@randall77 @toothrot
[release-branch.go1.14] runtime: special case interface hashing for p…
6717d27 
…ointers

Interfaces often contain pointers. Implement a fast path for this case.

name                   old time/op  new time/op  delta
MapInterfaceString-16  21.4ns ±19%  20.5ns ±10%     ~     (p=0.361 n=10+10)
MapInterfacePtr-16     25.8ns ± 8%  17.3ns ± 7%  -33.11%  (p=0.000 n=10+9)

We need this CL as well to fix 37721.
Update #37721
Fixes #37613

Change-Id: Ice52820e6259a3edeafcbbbeb25b1e363bef00d0
Reviewed-on: https://go-review.googlesource.com/c/go/+/219338
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
(cherry picked from commit afd691c)
Reviewed-on: https://go-review.googlesource.com/c/go/+/222779
Run-TryBot: Alexander Rakoczy <alex@golang.org>
@dmitshur dmitshur changed the title runtime: golang 1.14.rc1 3-5% performance regression from golang 1.13 during protobuf marshalling [1.14 backport] runtime: Go 1.14.rc1 3-5% performance regression from 1.13 during protobuf marshalling [1.14 backport] Mar 19, 2020
@golang golang locked and limited conversation to collaborators Mar 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.14.1
Development

No branches or pull requests
3 participants
@dmitshur @randall77 @gopherbot