Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding/base64: Add examples for Encode/Decode #37595

Closed
shihanng opened this issue Mar 2, 2020 · 8 comments
Closed

encoding/base64: Add examples for Encode/Decode #37595

shihanng opened this issue Mar 2, 2020 · 8 comments
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.18

Comments

@shihanng
Copy link

shihanng commented Mar 2, 2020

Currently we have examples for

However, it would be nice if we can also include the example for

to demonstrate how to do the encoding/decoding to/from byte slice values.

If this is okay, I can submit a CL for review.
@dmitshur
Copy link
Contributor

dmitshur commented Mar 2, 2020 •
edited

Having examples for those two methods should be helpful.

We want to make sure the examples are high quality and demonstrate good usage. We can ensure that's the case as part of the code review.

Please feel free to send a CL. Thanks.

/cc @rsc per owners.

@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 2, 2020
@dmitshur dmitshur added this to the Backlog milestone Mar 2, 2020
@shihanng
Copy link
Author

shihanng commented Mar 2, 2020

Thanks! I will start working on this.

@gopherbot
Copy link

Change https://golang.org/cl/221857 mentions this issue: encoding/base64: add examples for Encode, Decode

hugolgst added a commit to hugolgst/go that referenced this issue Mar 23, 2020
@hugolgst
encoding/base64: add Encode and Decode examples
5d00b2a 
Fixes golang#37595
hugolgst added a commit to hugolgst/go that referenced this issue Mar 23, 2020
@hugolgst
encoding/base64: add Decode example
1cee1be 
Updates golang#37595
hugolgst added a commit to hugolgst/go that referenced this issue Mar 23, 2020
@hugolgst
encoding/base64: add Encode example
292d398 
Fixes golang#37595
@hugolgst hugolgst mentioned this issue Mar 23, 2020
Closed
@gopherbot
Copy link

Change https://golang.org/cl/224899 mentions this issue: encoding/base64: add examples for Encode/Decode, fixes #37595

@zaneChou1
Copy link
Contributor

I am confused that the CL is abandoned without a reason and the issue is not closed.
Is it necessary to add a example for Encode ?

Change https://golang.org/cl/224899 mentions this issue: encoding/base64: add examples for Encode/Decode, fixes #37595

@shihanng
Copy link
Author

There was another CL submitted originally #37595 (comment) and still waiting to be reviewed.

@gopherbot
Copy link

Change https://golang.org/cl/348394 mentions this issue: encoding/base64: Add examples for Encode/Decode

@gopherbot
Copy link

Change https://golang.org/cl/351470 mentions this issue: encoding/base32: Add examples for Encode/Decode

gopherbot pushed a commit that referenced this issue Sep 27, 2021
@180909 @ianlancetaylor
encoding/base32: Add examples for Encode/Decode
f9a53b6 
Updates #37595

Change-Id: I7568e7416d5504e9dc67061c79f66e3a0d597dee
Reviewed-on: https://go-review.googlesource.com/c/go/+/351470
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: David Chase <drchase@google.com>
@dmitshur dmitshur modified the milestones: Backlog, Go1.18 Oct 23, 2021
@golang golang locked and limited conversation to collaborators Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.18
Development

Successfully merging a pull request may close this issue.

encoding/base64: add examples for Encode/Decode, fixes #37595 hugolgst/go
4 participants
@dmitshur @shihanng @gopherbot @zaneChou1