Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: support GitLab nested groups #37592

Closed
steve-mt opened this issue Mar 1, 2020 · 7 comments
Closed

x/pkgsite: support GitLab nested groups #37592

steve-mt opened this issue Mar 1, 2020 · 7 comments
Labels
FrozenDueToAge help wanted pkgsite WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
pkgsite/unplanned

Comments

@steve-mt
Copy link

steve-mt commented Mar 1, 2020

What did you do?

Visit https://pkg.go.dev/gitlab.com/gitlab-org/security-products/analyzers/common/v2

What did you expect to see?

A Go module showing godocs, show README, version. something similar to https://pkg.go.dev/gitlab.com/akita/akita?tab=doc

What did you see instead?

It's treated like a subdirectory o godocs, empty README.

Information

GitLab supported nested groups https://docs.gitlab.com/ee/user/group/subgroups/index.html#subgroups where you can have projects inside of those groups such as https://gitlab.com/gitlab-org/security-products/analyzers/common. This package should be considered as the root of the module.
@gopherbot gopherbot added this to the Unreleased milestone Mar 1, 2020
@julieqiu julieqiu changed the title go.dev: Support GitLab nested groups go.dev: support GitLab nested groups Mar 2, 2020
@julieqiu julieqiu added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. UX Issues that involve UXD/UXR input labels Mar 2, 2020
@julieqiu
Copy link
Member

julieqiu commented Mar 3, 2020

Thanks for the feedback! We're currently discussing this request with our UX team. We'll post on this issue with any updates.

/cc @fflewddur

@tnir
Copy link

tnir commented Mar 4, 2020

@steveazz Thanks for filing this 🙇

@julieqiu julieqiu changed the title go.dev: support GitLab nested groups x/pkgsite: support GitLab nested groups Jun 15, 2020
@julieqiu julieqiu added help wanted and removed UX Issues that involve UXD/UXR input labels Aug 20, 2020
@Rudde
Copy link

Rudde commented Mar 22, 2021

Ehh, it's been half a year, any plans to add this to the plan?

@julieqiu
Copy link
Member

https://pkg.go.dev/gitlab.com/gitlab-org/security-products/analyzers/common/v2 seems very similar to https://gitlab.com/gitlab-org/security-products/analyzers/common to me. Would you mind elaborating on what you're looking for?

@julieqiu julieqiu added WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Mar 22, 2021
@bcmills
Copy link
Contributor

bcmills commented Mar 22, 2021

There have been a number of GitLab bugs surrounding the go-import metadata they serve for subgroups; see:

It appears that some or all of them have been resolved within the past year or so.

It isn't clear to me whether those fixes have addressed the issues reported here.

@bcmills bcmills added WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. and removed WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. labels Mar 22, 2021
@gopherbot
Copy link
Contributor

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@tnir
Copy link

tnir commented Apr 23, 2021

As bugs on gitlab.com were fixed in 2020-10, this problem looks fixed now. Thanks for confirming.

@golang golang locked and limited conversation to collaborators Apr 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted pkgsite WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
pkgsite/unplanned
Development

No branches or pull requests
7 participants
@Rudde @bcmills @julieqiu @gopherbot @steve-mt @tnir and others