Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website/internal/dl: ?mode=json&include=all don't list older unstable releases when there are newer stable releases #37581

Closed
perillo opened this issue Feb 29, 2020 · 6 comments
Closed

x/website/internal/dl: ?mode=json&include=all don't list older unstable releases when there are newer stable releases #37581

perillo opened this issue Feb 29, 2020 · 6 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@perillo
Copy link
Contributor

perillo commented Feb 29, 2020

The documentation at https://godoc.org/golang.org/x/website/internal/dl says that

An additional query param, include=all, when used with the mode=json query param, will serve a full list of available downloads, including stable, unstable, and archived releases in JSON format

However currently https://golang.org/dl/?mode=json&include=all does not include unstable releases.

Another issue is that for go < 1.6, the SHA256 field is empty, but there is no SHA1 field that is instead present on the HTML page, in the archived versions section.
@gopherbot gopherbot added this to the Unreleased milestone Feb 29, 2020
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 29, 2020
@dmitshur dmitshur self-assigned this Feb 29, 2020
@dmitshur
Copy link
Contributor

The include=all query parameter was proposed in issue #29380 and implemented in CL 163741. The intention was to include all unstable releases. It looks like there's a bug in that implementation that's preventing older unstable releases from showing up when a newer stable release is available.

This bug needs to be fixed. We should add test cases for this so this behavior doesn't regress.

Another issue [...]

Mind filing a separate GitHub issue for that? I'm not sure if we'll want to fix it because those versions are old, but in any case, it'll be easier to discuss and track it separately.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Feb 29, 2020
@dmitshur dmitshur removed their assignment Feb 29, 2020
@dmitshur dmitshur changed the title x/website: dl/?mode=json&include=all don't list unstable releases x/website/internal/dl: ?mode=json&include=all don't list older unstable releases when there are newer stable releases Feb 29, 2020
@perillo
Copy link
Contributor Author

perillo commented Feb 29, 2020

Done: #37586

Thanks.

@ben-toogood ben-toogood mentioned this issue Jun 2, 2020
Closed
@dmitshur dmitshur mentioned this issue Sep 22, 2020
Open
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/290310 mentions this issue: internal/dl: include old unstable release in archive

@mvdan mvdan mentioned this issue Feb 7, 2021
Closed
@myitcv
Copy link
Member

myitcv commented Feb 7, 2021

Just to point out, per #43975, that every time this happens GitHub actions builds that are helpfully testing out new unstable versions stop working:

This is turn has caused any GitHub actions builds that have go1.16beta1 in their build matrices, kicked off since the release of rc1, to fail.

@myitcv
Copy link
Member

myitcv commented Feb 16, 2021

Just to reiterate the previous point that now Go 1.16 has been released all GitHub builds using rc1 have stopped working

@dmitshur
Copy link
Contributor

dmitshur commented Apr 5, 2021

This is fixed. Old pre-release Go versions are now considered archived rather than not being included at all, and they show up both at the bottom of https://golang.org/dl/#archive and in the API with when include=all is set.

Thanks for the report, and thanks to @seankhliao for investigating the problem and sending the fix CL.

@golang golang locked and limited conversation to collaborators Apr 5, 2022
MK825 added a commit to MK825/website that referenced this issue Oct 18, 2022
@MK825
internal/dl: include old unstable release in archive
a9146b0 
Updates golang/go#17574
Fixes golang/go#37581
Fixes golang/go#43975

Change-Id: I31cab4b8f8277b3c83ddde001f2649bb5f0bc9c7
Reviewed-on: https://go-review.googlesource.com/c/website/+/290310
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dmitshur @myitcv @perillo @gopherbot