Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/internal/lsp: test failures due to data corruption #37507

Closed
bcmills opened this issue Feb 27, 2020 · 4 comments
Closed

x/tools/internal/lsp: test failures due to data corruption #37507

bcmills opened this issue Feb 27, 2020 · 4 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Feb 27, 2020

This could be a symptom of #37269, of #36605, or of some other undiagnosed memory-corruption bug. (I note goroutines in both golang.org/x/tools/go/packages.Load and golang.org/x/tools/internal/fastwalk.Walk in the stack dump.)

https://build.golang.org/log/4924e7126d7b849af0daebadc00289e321818f5e

020/02/26 22:48:02 no dep handle: no metadata for nosuchpkg
	package = nosuchpkg
2020/02/26 22:48:15 unable to compute error positions: no file for  in package golang.org/x/tools/internal/lsp/danglingstmt
	package = golang.org/x/tools/internal/lsp/danglingstmt
2020/02/26 22:48:15 unable to compute error positions: no file for  in package golang.org/x/tools/internal/lsp/danglingstmt
	package = golang.org/x/tools/internal/lsp/danglingstmt
2020/02/26 22:48:44 initial workspace load failed: couldn't run 'go': chdir /tmp/workdir/tmp/TestLSP_GOPATH210517143/lsp/src: no such file or directory
2020/02/26 22:48:44 initial workspace load failed: err: exit status 1: stderr: 2020/02/26 22:48:44 cannot determine current directory: getwd: no such file or directory

2020/02/26 22:49:32 no dep handle: no metadata for nosuchpkg
	package = nosuchpkg
2020/02/26 22:49:41 unable to compute error positions: no file for  in package golang.org/x/tools/internal/lsp/danglingstmt
	package = golang.org/x/tools/internal/lsp/danglingstmt
2020/02/26 22:49:41 unable to compute error positions: no file for  in package golang.org/x/tools/internal/lsp/danglingstmt
	package = golang.org/x/tools/internal/lsp/danglingstmt
2020/02/26 22:49:52 diagnose: could not generate diagnostics for go.mod file: err: exit status 1: stderr: golang.org/x/tools/internal/lsp/bad imports
	nosuchpkg: package nosuchpkg is not in GOROOT (/tmp/workdir/go/src/nosuchpkg)

2020/02/26 22:49:54 quick fixes failed: err: exit status 1: stderr: golang.org/x/tools/internal/lsp/bad imports
	nosuchpkg: package nosuchpkg is not in GOROOT (/tmp/workdir/go/src/nosuchpkg)

	file = file:///tmp/workdir/tmp/TestLSP_Modules744837051/lsp/suggestedfix/has_suggested_fix.go
fatal error: unexpected signal during runtime execution
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x0]
…
FAIL	golang.org/x/tools/internal/lsp	161.038s

CC @findleyr @stamblerre @ianthehat @matloob

@gopherbot gopherbot added this to the Unreleased milestone Feb 27, 2020
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 27, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 27, 2020
@stamblerre
Copy link
Contributor

/cc @heschik

@golang golang deleted a comment from gopherbot Feb 27, 2020
@heschi
Copy link
Contributor

heschi commented Feb 27, 2020

Freebsd doesn't have an oversized dirent, so I don't think it was #37269. I fixed it anyway. I don't have any good guesses for the correct cause.

@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.4.0 Mar 2, 2020
@bcmills
Copy link
Contributor Author

bcmills commented Mar 5, 2020

See also #37602, #37690.

@heschi
Copy link
Contributor

heschi commented Jun 16, 2020

Glancing at the builders, I don't see any occurrences. Closing.

@heschi heschi closed this as completed Jun 16, 2020
@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v0.4.2 Jun 18, 2020
@golang golang locked and limited conversation to collaborators Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

4 participants