Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time: racy Timer access should either work or throw, not panic [1.14 backport] #37494

Closed
gopherbot opened this issue Feb 27, 2020 · 3 comments
Closed

time: racy Timer access should either work or throw, not panic [1.14 backport] #37494

gopherbot opened this issue Feb 27, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.14.1

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #37400 to be considered for backport to the next 1.14 minor release.

@gopherbot Please open a backport to 1.14.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 27, 2020
@gopherbot gopherbot mentioned this issue Feb 27, 2020
Closed
@gopherbot gopherbot added this to the Go1.14.1 milestone Feb 27, 2020
@gopherbot
Copy link
Author

Change https://golang.org/cl/221298 mentions this issue: [release-branch.go1.14] runtime: don't panic on racy use of timers

@dmitshur
Copy link
Contributor

Approving because it is a serious issue without a workaround.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Feb 27, 2020
@gopherbot
Copy link
Author

Closed by merging 3293174 to release-branch.go1.14.

gopherbot pushed a commit that referenced this issue Feb 27, 2020
@ianlancetaylor
[release-branch.go1.14] runtime: don't panic on racy use of timers
3293174 
If we see a racy use of timers, as in concurrent calls to Timer.Reset,
do the operations in an unpredictable order, rather than crashing.

Updates #37400
Updates #37449
Fixes #37494

Change-Id: Idbac295df2dfd551b6d762909d5040fc532c1b34
Reviewed-on: https://go-review.googlesource.com/c/go/+/221077
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
(cherry picked from commit 98858c4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/221298
@Jamesits Jamesits mentioned this issue Mar 27, 2020
Closed
@bcmills bcmills mentioned this issue Apr 2, 2020
Closed
@golang golang locked and limited conversation to collaborators Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.14.1
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot