Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: add slowbots heuristics #37454

Open
josharian opened this issue Feb 25, 2020 · 4 comments
Open

x/build: add slowbots heuristics #37454

josharian opened this issue Feb 25, 2020 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@josharian
Copy link
Contributor

Slowbots are awesome, but manual, and thus error-prone.

We could add some heuristics to automatically trigger appropriate slowbots. For example, any change that touches cmd/compile/internal/ssa/rewrite_ARCH.go should trigger slowbots for that arch (or set of arches). Similarly for any file named whatever_ARCH.s. Probably something similar for files named whatever_OS.go.

We could start small and improve heuristics over time. There'd be a few false positives, but probably few enough that it'd be worth it.

cc @bcmills @dmitshur
@gopherbot gopherbot added this to the Unreleased milestone Feb 25, 2020
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Feb 25, 2020
@mvdan
Copy link
Member

mvdan commented Feb 25, 2020

Can I give ten thumbs up? :)

I think we could make this a bit smarter than just "did this file change at all?". For example, for Go files, we could ignore formatting and comment changes by comparing the before and after through go/format after dropping all comments. This isn't foolproof, because some relevantcomments like // +build, but this might help us with false positives.

@cagedmantis cagedmantis added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Feb 26, 2020
@cagedmantis
Copy link
Contributor

/cc @dmitris @toothrot

@dmitris
Copy link
Contributor

dmitris commented Mar 2, 2020

fwd /cc @dmitshur

@dmitshur
Copy link
Contributor

dmitshur commented Mar 2, 2020 •
edited

This sounds very reasonable to consider, thanks for the suggestion. There are 2 concerns to be mindful of.

Slowbots are currently very limited resources, and I want to ensure this doesn’t lead to them becoming exhausted. We can adjust things as you said, so it should be a manageable problem. Can also turn it into from automatically starting to just posting a comment with a suggestion.

Secondly, it’d be nice to prototype this first before committing to this feature. I’d like to see how much code and work it’ll take to make this happen.

@dmitshur dmitshur added help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. FeatureRequest and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
6 participants
@dmitris @josharian @cagedmantis @dmitshur @mvdan @gopherbot