Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/lsp/lsprpc: TestDebugInfoLifecycle is flaky #37444

Closed
bcmills opened this issue Feb 25, 2020 · 3 comments
Closed

x/tools/internal/lsp/lsprpc: TestDebugInfoLifecycle is flaky #37444

bcmills opened this issue Feb 25, 2020 · 3 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.4.0

Comments

@bcmills
Copy link
Contributor

bcmills commented Feb 25, 2020

https://build.golang.org/log/fbfefd18c9b55e2e3dcb6f7a3010e3d2b9615a31

It isn't clear to me whether this is a bug in the test itself or in the code under test.

2020/02/25 14:48:16 : context canceled
2020/02/25 14:48:16 : context canceled
2020/02/25 14:48:16 : context canceled
2020/02/25 14:48:16 closed a connection with error: disconnected
2020/02/25 14:48:16 forwarder: gopls handshake failed: context canceled
2020/02/25 14:48:16 : forwarder: gopls path mismatch: forwarder is "/workdir/tmp/go-build615687836/b640/lsprpc.test", remote is ""
--- FAIL: TestDebugInfoLifecycle (0.65s)
    lsprpc_test.go:217: len(client:Servers) = 0, want 1
FAIL
FAIL	golang.org/x/tools/internal/lsp/lsprpc	0.694s

CC @stamblerre @ianthehat
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 25, 2020
@gopherbot gopherbot added this to the Unreleased milestone Feb 25, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 25, 2020
@stamblerre
Copy link
Contributor

@findleyr: can you take a look?

@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.4.0 Feb 25, 2020
@findleyr findleyr self-assigned this Feb 25, 2020
@findleyr
Copy link
Contributor

This is a bug in the test: the client-server handshake happens asynchronously, so may not have occurred by the time of that test assertion. I can repro locally by adding a sleep before the handshake. My bad.

Fix incoming.

@gopherbot
Copy link

Change https://golang.org/cl/220903 mentions this issue: internal/lsp/lsprpc: wait for the handshake before running clientConn

@golang golang locked and limited conversation to collaborators Feb 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.4.0
Development

No branches or pull requests
4 participants
@bcmills @stamblerre @gopherbot @findleyr