Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: golang 1.14.rc1 3-5% performance regression from golang 1.13 during protobuf marshalling [1.12 backport] #37420

Closed
gopherbot opened this issue Feb 24, 2020 · 1 comment
Closed

runtime: golang 1.14.rc1 3-5% performance regression from golang 1.13 during protobuf marshalling [1.12 backport] #37420

gopherbot opened this issue Feb 24, 2020 · 1 comment
Labels
FrozenDueToAge
Milestone
Go1.12.18

Comments

@gopherbot
Copy link

@randall77 requested issue #37086 to be considered for backport to the next 1.12 minor release.

@gopherbot please open a backport issue.

I don't think this performance regression qualifies for a backport, but I'll let the release guys make that call.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 24, 2020
@gopherbot gopherbot mentioned this issue Feb 24, 2020
Closed
@gopherbot gopherbot added this to the Go1.12.18 milestone Feb 24, 2020
@randall77
Copy link
Contributor

randall77 commented Feb 24, 2020 •
edited by dmitshur

Don't need to go back to 1.12, the performance regression was introduced in 1.14.

Edit by @dmitshur: Edited to say it was introduced in 1.14, not 1.13.

@dmitshur dmitshur removed the CherryPickCandidate Used during the release process for point releases label Feb 26, 2020
@golang golang locked and limited conversation to collaborators Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.12.18
Development

No branches or pull requests
3 participants
@dmitshur @randall77 @gopherbot