Skip to content

crypto/cipher: NewGCMWithNonceSize allows zero-length nonce [1.14 backport] #37416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Feb 24, 2020 · 5 comments
Closed

crypto/cipher: NewGCMWithNonceSize allows zero-length nonce [1.14 backport] #37416

gopherbot opened this issue Feb 24, 2020 · 5 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.14

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Feb 24, 2020 •
edited by dmitshur
Loading

@networkimprov requested issue #37118 to be considered for inclusion in the 1.14 release.

@gopherbot please open backport, at suggestion of @FiloSottile.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 24, 2020
@gopherbot gopherbot mentioned this issue Feb 24, 2020
Closed
@gopherbot gopherbot added this to the Go1.12.18 milestone Feb 24, 2020
@dmitshur dmitshur changed the title crypto/cipher: NewGCMWithNonceSize allows zero-length nonce [1.12 backport] crypto/cipher: NewGCMWithNonceSize allows zero-length nonce [1.14 backport] Feb 24, 2020
@dmitshur dmitshur modified the milestones: Go1.12.18, Go1.14 Feb 24, 2020
@networkimprov
Copy link

@dmitshur there are 3 other issues in the queue for 1.12.18, so why wouldn't this be included?

@dmitshur
Copy link
Contributor

Ok, let's not take shortcuts. Opened #37418 for the 1.12 backport.

@dmitshur
Copy link
Contributor

Approving this backport. It's a small security hardening fix.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Feb 24, 2020
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/220651 mentions this issue: [release-branch.go1.14] crypto/cipher: require non-zero nonce size for AES-GCM

@gopherbot
Copy link
Contributor Author

Closed by merging f63e55b to release-branch.go1.14.

gopherbot pushed a commit that referenced this issue Feb 24, 2020
@katiehockman @dmitshur
[release-branch.go1.14] crypto/cipher: require non-zero nonce size fo…
f63e55b 
…r AES-GCM

Also fix typo in crypto/cipher/gcm_test.go.

Updates #37118
Fixes #37416

Change-Id: I8544d1eeeb1f0336cebb977b8c5bfa5e4c5ad8c7
Reviewed-on: https://go-review.googlesource.com/c/go/+/218500
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
(cherry picked from commit 4e8badb)
Reviewed-on: https://go-review.googlesource.com/c/go/+/220651
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@golang golang locked and limited conversation to collaborators Feb 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.14
Development

No branches or pull requests
3 participants
@networkimprov @dmitshur @gopherbot