Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/exp/cmd/gorelease: support for using @latest as a version #37410

Closed
myitcv opened this issue Feb 24, 2020 · 2 comments
Closed

x/exp/cmd/gorelease: support for using @latest as a version #37410

myitcv opened this issue Feb 24, 2020 · 2 comments
Labels
FeatureRequest FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@myitcv
Copy link
Member

myitcv commented Feb 24, 2020

What version of Go are you using (go version)?

$ go version
go version devel +151ccd4bdb Mon Feb 24 02:36:05 2020 +0000 linux/amd64
$ git rev-parse HEAD
7c80518d1cc79ffde9e571fe4fd281f321d36200

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/myitcv/.cache/go-build"
GOENV="/home/myitcv/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/myitcv/gostuff"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/myitcv/gos"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build193807698=/tmp/go-build -gno-record-gcc-switches"

What did you do?

$ gorelease -base=latest

What did you expect to see?

A comparison with the latest semver version, resolved via proxy.golang.org

What did you see instead?

usage: gorelease -base=version [-version=version]
base version "latest" is not a canonical semantic version
For more information, run go doc golang.org/x/exp/cmd/gorelease

cc @jayconrod
@gopherbot gopherbot added this to the Unreleased milestone Feb 24, 2020
@jayconrod jayconrod mentioned this issue Feb 24, 2020
Closed
@bcmills
Copy link
Contributor

bcmills commented Feb 24, 2020

That reminds me, I owe @jayconrod a code review on CL 216078.

I think latest makes sense as the default value inferred for -base, although it probably should be supported as an explicit value as well.

@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 27, 2020
@jayconrod jayconrod changed the title x/exp/gorelease: support for using @latest as a version x/exp/cmd/gorelease: support for using @latest as a version Feb 28, 2020
@jayconrod jayconrod mentioned this issue May 21, 2020
Open
@gopherbot
Copy link

Change https://golang.org/cl/236598 mentions this issue: cmd/gorelease: accept version queries for -base

@golang golang locked and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@cagedmantis @jayconrod @myitcv @bcmills @gopherbot