Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/trace: requires HTML imports, which doesn't work on any major browser anymore [1.14 backport] #37343

Closed
gopherbot opened this issue Feb 20, 2020 · 4 comments
Closed

cmd/trace: requires HTML imports, which doesn't work on any major browser anymore [1.14 backport] #37343

gopherbot opened this issue Feb 20, 2020 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.14.1

Comments

@gopherbot
Copy link

@hyangah requested issue #34374 to be considered for backport to the next 1.14 minor release.

I just submitted cl/219997. We think this is too risky to include to 1.14. We plan to add it to the first patch release. Meanwhile, you can compile or download the latest developer version of Go (e.g. https://godoc.org/golang.org/dl/gotip) and use the execution tracer included in it.

@gopherbot please backport to 1.13 and 1.14
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 20, 2020
@gopherbot gopherbot mentioned this issue Feb 20, 2020
Closed
@gopherbot

This comment has been minimized.

Sign in to view
@gopherbot
Copy link
Author

Change https://golang.org/cl/220323 mentions this issue: [release-branch.go1.14] cmd/trace: update to use WebComponents V0 polyfill

@gopherbot gopherbot added this to the Go1.14.1 milestone Feb 26, 2020
@dmitshur
Copy link
Contributor

dmitshur commented Mar 2, 2020

Approving because this is a serious issue for cmd/trace without a reasonable workaround. The fix is contained to the cmd/trace command.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Mar 2, 2020
@gopherbot
Copy link
Author

Closed by merging e6036e7 to release-branch.go1.14.

gopherbot pushed a commit that referenced this issue Mar 2, 2020
@hyangah @dmitshur
[release-branch.go1.14] cmd/trace: update to use WebComponents V0 pol…
e6036e7 
…yfill

Old trace viewer stopped working with Chrome M80+ because the
old trace viewer heavily depended on WebComponents V0 which are deprecated.
Trace viewer recently migrated to use WebComponents V0 polyfill
(crbug.com/1036492). This CL brings in the newly updated trace_viewer_full.html
(sync'd @ 9508452e)
and updates the javascript snippet included in the /trace endpoint
to use the polyfill.

This brings in webcomponents.min.js copied from
https://chromium.googlesource.com/catapult/+/9508452e18f130c98499cb4c4f1e1efaedee8962/third_party/polymer/components/webcomponentsjs/webcomponents.min.js

That is necessary because the /trace endpoint needs to import
the vulcanized trace_viewer_full.html.

It's possible that some features are not working correctly with
this polyfill. In that case, report the issue to crbug.com/1036492.
There will be a warning message in the UI (yellow banner above the timeline)
which can be hidden by clicking the 'hide' button.

This allows to render the trace in browsers other than chrome in theory,
but I observed some buttons and functions still don't work outside
chrome.

Updates #34374.
Fixes #37343.

Change-Id: I0f369b15349dd0f4718c261ec23dfab6a47ace2f
Reviewed-on: https://go-review.googlesource.com/c/go/+/219997
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Austin Clements <austin@google.com>
(cherry picked from commit 75ea964)
Reviewed-on: https://go-review.googlesource.com/c/go/+/220323
@seankhliao seankhliao mentioned this issue Mar 24, 2020
Closed
@golang golang locked and limited conversation to collaborators Mar 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.14.1
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot