x/net/internal/socket: TestRace is flaky #37338
Comments
bcmills
added
Testing
|
This test flakes quite frequently; it really ought to be fixed. Marking as release-blocker for Go 1.17 via #11811. |
|
Another TryBot failure: https://storage.googleapis.com/go-build-log/5e94fe93/linux-amd64-race_c33a9e97.log (from https://golang.org/cl/295569) |
|
This keeps flaking on almost every TryBot run for |
|
Sure!
…On Tue, Mar 23, 2021 at 3:43 AM Tobias Klauser ***@***.***> wrote:
This keeps flaking on almost every TryBot run for golang.org/x/net (see
e.g. https://golang.org/cl/303909 for a recent example). Should we
temporarily skip the test?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#37338 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFL3V2NP7U37WPXRASXY4LTFBWG3ANCNFSM4KYT5L3A>
.
|
|
Change https://golang.org/cl/303910 mentions this issue: |
This test keeps flaking on almost every TryBot run. Skip it for now. For golang/go#37338 Change-Id: I77cdd782f3bc164ec11894683aa50c3441807ba5 Reviewed-on: https://go-review.googlesource.com/c/net/+/303910 Trust: Tobias Klauser <tobias.klauser@gmail.com> Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com> Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com> Reviewed-by: Bryan C. Mills <bcmills@google.com> TryBot-Result: Go Bot <gobot@golang.org>
|
Change https://golang.org/cl/310269 mentions this issue: |
For golang/go#37338 Change-Id: I00c222ee15bce07438ac56c0dfe4770897eccbbd Reviewed-on: https://go-review.googlesource.com/c/net/+/310269 Trust: Ian Lance Taylor <iant@golang.org> Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com> Reviewed-by: Bryan C. Mills <bcmills@google.com>
|
Another occurrence on a trybot. The additional logging was not helpful. https://storage.googleapis.com/go-build-log/7e97e4e8/linux-amd64-race_f089a4dd.log |
|
The test works by using |
|
Never mind, that should be ensured by the go.mod file. |
|
OK, I can recreate this about 10% of the time by invoking |
|
Change https://golang.org/cl/312529 mentions this issue: |
An example from the
linux-amd64-fedorabuilder: https://build.golang.org/log/3d48fc241a76a29308028aa219a2114b4c0a5b7bI have seen this failure many other times as well, but I can't easily collect them due to #35515.
CC @randall77 @odeke-em
The text was updated successfully, but these errors were encountered: