Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time: TestTicker failures on netbsd-amd64-8_0 builder #37332

Closed
bcmills opened this issue Feb 20, 2020 · 4 comments
Closed

time: TestTicker failures on netbsd-amd64-8_0 builder #37332

bcmills opened this issue Feb 20, 2020 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-NetBSD OS-OpenBSD
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Feb 20, 2020 

--- FAIL: TestTicker (1.26s)
    tick_test.go:70: saw 5 errors
    tick_test.go:32: 10 20ms ticks took 250.987124ms, expected [160ms,240ms]
    tick_test.go:32: 10 20ms ticks took 251.555254ms, expected [160ms,240ms]
    tick_test.go:32: 10 20ms ticks took 251.282407ms, expected [160ms,240ms]
    tick_test.go:32: 10 20ms ticks took 251.501105ms, expected [160ms,240ms]
    tick_test.go:32: 10 20ms ticks took 251.463514ms, expected [160ms,240ms]
FAIL
FAIL	time	4.698s

We may just need to widen the accepted intervals a bit on this builder.

See also #35692.

CC @ianlancetaylor

2020-02-15T16:40:12-6917529/netbsd-amd64-8_0
2020-02-05T22:19:16-e5b9c10/netbsd-amd64-8_0
@bcmills bcmills added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Feb 20, 2020
@bcmills bcmills added this to the Backlog milestone Feb 20, 2020
@katiehockman
Copy link
Contributor

Saw the same flake in openbsd-amd64-68 today

--- FAIL: TestTicker (1.81s)
    tick_test.go:79: saw 5 errors
    tick_test.go:37: 10 20ms ticks took 361.739892ms, expected [240ms,360ms]
    tick_test.go:37: 10 20ms ticks took 362.25355ms, expected [240ms,360ms]
    tick_test.go:37: 10 20ms ticks took 362.221384ms, expected [240ms,360ms]
    tick_test.go:37: 10 20ms ticks took 362.225653ms, expected [240ms,360ms]
    tick_test.go:37: 10 20ms ticks took 362.289081ms, expected [240ms,360ms]
FAIL
FAIL	time	5.030s
FAIL

Full log: openbsd-amd64-68_399b8d79.log.txt

@ianlancetaylor
Copy link
Contributor

2021-04-20T15:45:02-9dd71ba/openbsd-amd64-68
2021-03-30T21:20:51-e0ce0af/linux-ppc64le-buildlet
2020-12-21T17:56:36-53c984d/openbsd-amd64-68
2020-11-13T15:00:23-35455ff/netbsd-386-9_0
2020-10-28T21:52:53-615c7c1/netbsd-386-9_0

@gopherbot
Copy link

Change https://golang.org/cl/313849 mentions this issue: time: increase slop for TestTicker

@ianlancetaylor
Copy link
Contributor

The test is inherently flaky. CL 313849 will increase the slop, which in itself will fix all but one of the recent failures. I also added a sleep at each attempt to try to get past an overloaded system.

@bcmills bcmills mentioned this issue Jun 1, 2021
Closed
@golang golang locked and limited conversation to collaborators Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-NetBSD OS-OpenBSD
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@ianlancetaylor @bcmills @gopherbot @katiehockman