Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestDialCancel failure on linux-arm with "network is unreachable" #37330

Closed
bcmills opened this issue Feb 20, 2020 · 2 comments
Closed

net: TestDialCancel failure on linux-arm with "network is unreachable" #37330

bcmills opened this issue Feb 20, 2020 · 2 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Feb 20, 2020

In the fix for #15191, we skipped the test in case of a connection refused error.
It looks like we may need to widen that to network is unreachable as well.

--- FAIL: TestDialCancel (0.00s)
    dial_test.go:820: dial error after 0 ticks (5 before cancel sent): dial tcp 198.18.0.254:1234: connect: network is unreachable
FAIL
FAIL	net	27.044s

CC @ianlancetaylor @bradfitz

2020-02-19T20:40:29-2200b4f/linux-arm
2020-01-23T21:01:12-ace25f8/linux-arm
2020-01-09T17:52:05-cec535b/linux-arm
2020-01-06T15:47:02-72f92de/linux-arm
2020-01-06T02:46:02-c6e8426/linux-arm
2019-11-18T18:14:37-f9dd99c/linux-arm
2019-10-30T08:17:29-f4e32ae/linux-arm
2019-10-24T08:47:14-722b0e3/linux-arm
2019-10-23T18:41:38-7833302/linux-arm
2019-10-11T17:03:37-df38069/linux-arm
2019-09-25T04:18:18-7fc2625/linux-arm
2019-09-06T20:05:29-5e43856/linux-arm
2019-09-01T02:31:50-d15dfdc/linux-arm
2019-08-02T17:51:34-2d1a1e0/linux-arm
2019-06-19T07:09:13-18107ed/linux-arm
2019-06-14T19:37:52-f18aeb3/linux-arm
2019-05-16T03:25:01-dccd5da/linux-arm
2019-05-02T20:30:31-0a338f7/linux-arm
2019-04-30T20:26:36-85387aa/linux-arm
2019-04-30T17:45:16-1fd1408/linux-arm
2019-04-27T17:15:55-17a7f21/linux-arm
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Feb 20, 2020
@bcmills bcmills added this to the Backlog milestone Feb 20, 2020
@bcmills
Copy link
Contributor Author

bcmills commented Sep 16, 2020

2020-09-15T05:08:53-3b64e6b/linux-arm
2020-09-06T17:26:55-617f2c3/linux-arm
2020-09-01T19:33:24-ac55d58/linux-arm
2020-07-30T16:00:05-54e75e8/linux-arm
2020-07-09T20:09:55-504db53/linux-arm
2020-07-08T19:50:20-9699086/linux-arm
2020-06-10T03:27:28-2a4e71c/linux-arm
2020-05-24T17:46:52-828bb0c/linux-arm
2020-05-07T04:05:18-94e61ab/linux-arm
2020-04-19T03:12:32-a32262d/linux-arm
2020-04-17T01:07:31-843453d/linux-arm
2020-02-22T15:25:30-638df87/linux-arm
2020-02-21T18:26:29-ae7cd5c/linux-arm

@qmuntal
Copy link
Contributor

qmuntal commented May 22, 2023

CL 496037 should have fixed this issue.

@qmuntal qmuntal closed this as completed May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@qmuntal @bcmills