Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestTLSHandshakeTimeout failure on solaris-amd64-oraclerel builder #37327

Closed
bcmills opened this issue Feb 20, 2020 · 2 comments
Closed

net/http: TestTLSHandshakeTimeout failure on solaris-amd64-oraclerel builder #37327

bcmills opened this issue Feb 20, 2020 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.15

Comments

@bcmills
Copy link
Contributor

bcmills commented Feb 20, 2020 

--- FAIL: TestTLSHandshakeTimeout (10.17s)
    serve_test.go:3636: Timeout expired after 10s
FAIL
FAIL	net/http	15.953s

2020-02-19T22:59:15-c4c73ce/solaris-amd64-oraclerel

This looks to me like a too-short hard-coded timeout.

CC @bradfitz
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 20, 2020
@bcmills bcmills added this to the Backlog milestone Feb 20, 2020
@bcmills bcmills added the Testing An issue that has been verified to require only test changes, not just a test failure. label Mar 27, 2020
@bcmills bcmills self-assigned this Mar 27, 2020
@bcmills bcmills modified the milestones: Backlog, Go1.15 Mar 27, 2020
@gopherbot
Copy link

Change https://golang.org/cl/225977 mentions this issue: net/http: remove arbitrary timeouts from TestIdentityResponse and TestTLSHandshakeTimeout

@gopherbot
Copy link

Change https://golang.org/cl/226137 mentions this issue: net/http: remove another arbitrary timeout in TestTLSHandshakeTimeout

@golang golang locked and limited conversation to collaborators Mar 27, 2021
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.15
Development

No branches or pull requests
2 participants
@bcmills @gopherbot