Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http: TestServer_RejectsLargeFrames failure with "Error while expecting a GOAWAY frame: EOF" on plan9-arm builder #37321

Closed
bcmills opened this issue Feb 20, 2020 · 1 comment
Closed

x/net/http: TestServer_RejectsLargeFrames failure with "Error while expecting a GOAWAY frame: EOF" on plan9-arm builder #37321

bcmills opened this issue Feb 20, 2020 · 1 comment
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Feb 20, 2020

https://build.golang.org/log/e0d21081e2f05f65ea83f6fb8c01970f152d4736

--- FAIL: TestServer_RejectsLargeFrames (0.16s)
    server_test.go:548: Error while expecting a GOAWAY frame: EOF
    server_test.go:238: Framer read log:
        2020-02-20 09:20:11.857323902 Framer 0x12570000: read SETTINGS len=24, settings: MAX_FRAME_SIZE=1048576, MAX_CONCURRENT_STREAMS=250, MAX_HEADER_LIST_SIZE=1048896, INITIAL_WINDOW_SIZE=1048576
        2020-02-20 09:20:11.861012807 Framer 0x12570000: read SETTINGS flags=ACK len=0
        2020-02-20 09:20:11.861144803 Framer 0x12570000: read WINDOW_UPDATE len=4 (conn) incr=983041
    server_test.go:244: Framer write log:
        2020-02-20 09:20:11.852591152 Framer 0x12570000: wrote SETTINGS len=0
        2020-02-20 09:20:11.8574199 Framer 0x12570000: wrote SETTINGS flags=ACK len=0
        2020-02-20 09:20:11.891919625 Framer 0x12570000: wrote UNKNOWN_FRAME_TYPE_255 len=1048577
http2.test 1563: warning: process exceeds 100 file descriptors
FAIL
FAIL	golang.org/x/net/http2	86.544s

Possibly related to #13434.

I couldn't easily check for other occurrences due to #35515.
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 20, 2020
@gopherbot gopherbot added this to the Unreleased milestone Feb 20, 2020
@gopherbot
Copy link

Change https://golang.org/cl/231877 mentions this issue: http2: skip OS-dependent tests on Plan 9

@golang golang locked and limited conversation to collaborators May 19, 2021
dteh pushed a commit to dteh/fhttp that referenced this issue Jun 22, 2022
@0intro
http2: skip OS-dependent tests on Plan 9
111f0d0 
In x/net/http2, tests TestServer_RejectsLargeFrames and
TestTransportBodyReadError_* are disabled on Windows because
they fail or flake, being dependent on the behaviour of the
OS network implementation when a connection is closed during
a large write.

The tests fail on Plan 9 for the same reason, so they should be
disabled there as well.

Workaround for golang/go#31260

Fixes golang/go#37321

Change-Id: Ifa1766eaa515c419fc4192126aaf796beefead0a
Reviewed-on: https://go-review.googlesource.com/c/net/+/231877
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot