-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/net/ipv6: TestPacketConnReadWriteMulticastUDP failures with "sendmsg: no buffer space available" on Darwin builders #37319
Comments
Change https://golang.org/cl/366181 mentions this issue: |
Change https://golang.org/cl/369742 mentions this issue: |
These deadlines were added back in CL 21080043, apparently in an attempt to increase code coverage numbers. However, nothing in the tests actually exercises the deadline logic: the tests would pass even if these methods were no-ops. Their only apparent effect is to make the tests flaky on slower builders, and to destroy goroutine traces if the test should ever happen to deadlock. Updates golang/go#42064 For golang/go#37319 Change-Id: I530a8f3cb80d6d93d1625bc88f0ec7958d4ec35e Reviewed-on: https://go-review.googlesource.com/c/net/+/366181 Trust: Bryan Mills <bcmills@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
Change https://golang.org/cl/376095 mentions this issue: |
This change is sheer speculation based on the failures observed in golang/go#37319. (A deadlock in the test prevented us from seeing the actual failure mode of golang/go#50455 up until CL 376094, and it isn't obvious to me that we should wait for another failure before trying a likely — and otherwise harmless — fix.) Fixes golang/go#50455. (Maybe.) Change-Id: I7483eb2243832d07cb1f815da196b3978a50c6b3 Reviewed-on: https://go-review.googlesource.com/c/net/+/376095 Trust: Bryan Mills <bcmills@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
Change https://go.dev/cl/387916 mentions this issue: |
Change https://go.dev/cl/387916 mentions this issue: |
This change is sheer speculation based on the failures observed in golang/go#37319. (A deadlock in the test prevented us from seeing the actual failure mode of golang/go#51342 up until CL 387915, and it isn't obvious to me that we should wait for another failure before trying a likely — and otherwise harmless — fix.) This is a port of CL 376095 to the "ipv4" package. Fixes golang/go#51342. (Maybe.) Change-Id: Idd6d2d785dbb0c98404f99bd98a3c4ddc11cb2cf Reviewed-on: https://go-review.googlesource.com/c/net/+/387916 Trust: Bryan Mills <bcmills@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
This change is sheer speculation based on the failures observed in golang/go#37319. (A deadlock in the test prevented us from seeing the actual failure mode of golang/go#50455 up until CL 376094, and it isn't obvious to me that we should wait for another failure before trying a likely — and otherwise harmless — fix.) Fixes golang/go#50455. (Maybe.) Change-Id: I7483eb2243832d07cb1f815da196b3978a50c6b3 Reviewed-on: https://go-review.googlesource.com/c/net/+/376095 Trust: Bryan Mills <bcmills@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
This change is sheer speculation based on the failures observed in golang/go#37319. (A deadlock in the test prevented us from seeing the actual failure mode of golang/go#51342 up until CL 387915, and it isn't obvious to me that we should wait for another failure before trying a likely — and otherwise harmless — fix.) This is a port of CL 376095 to the "ipv4" package. Fixes golang/go#51342. (Maybe.) Change-Id: Idd6d2d785dbb0c98404f99bd98a3c4ddc11cb2cf Reviewed-on: https://go-review.googlesource.com/c/net/+/387916 Trust: Bryan Mills <bcmills@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
https://build.golang.org/log/68089cd321b1639f48b00bd770b720c7657b6b4b
https://build.golang.org/log/2a7e7be249a02c8f432a1ee5a987ddccee1fe668
I couldn't check for older occurrences due to #35515.
The text was updated successfully, but these errors were encountered: