Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/internal/gcimporter: remove support for binary import/export format #37312

Closed
griesemer opened this issue Feb 20, 2020 · 7 comments
Closed
Labels
early-in-cycle A change that should be done early in the 3 month dev cycle. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@griesemer
Copy link
Contributor

Now that we have removed support for the (defunct) binary import/export format in the std library, investigate if we can remove the corresponding code in the x/tools version.

Reminder issue.

@gopherbot gopherbot added this to the Unreleased milestone Feb 20, 2020
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Feb 20, 2020
@griesemer
Copy link
Contributor Author

Related: #27999.
cc: @stamblerre

@griesemer griesemer added early-in-cycle A change that should be done early in the 3 month dev cycle. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Feb 20, 2020
@griesemer griesemer modified the milestones: Unreleased, Go1.15 Feb 20, 2020
@griesemer
Copy link
Contributor Author

Assuming we can do this, setting milestone to 1.15 so we can do this in sync with the std/lib change.

@mvdan
Copy link
Member

mvdan commented Apr 25, 2020

I assume we're not in a hurry to do this before the freeze, given that the code is in another repository? The early-in-cycle label is confusing me a bit, since the corresponding standard library change was merged some weeks ago.

@griesemer
Copy link
Contributor Author

It should be safe to remove since the code is presumably not in use anymore, but I defer to @stamblerre who knows better which code is is use now. There's no rush, but at the same time we've been schlepping this code around for a few years now. It would be nice to get rid of it.

@gopherbot
Copy link

Change https://golang.org/cl/229987 mentions this issue: go/internal/gcimporter: remove support for binary export data

@stamblerre
Copy link
Contributor

I agree, it should be safe to delete. Just mailed a CL to do it.

@stamblerre
Copy link
Contributor

@heschik notes that this will break any tool relying on export data for older versions of Go. We only maintain tools for the current and previous versions of Go (1.14 and 1.13, right now), so we wouldn't be breaking any guarantees. However, we may still get some complaints. I will merge this CL, but if enough people file issues, we may have to roll it back.

@golang golang locked and limited conversation to collaborators Apr 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
early-in-cycle A change that should be done early in the 3 month dev cycle. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

4 participants