Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: incorrect active parameter in signature help #37271

Closed
kliko9 opened this issue Feb 17, 2020 · 3 comments
Closed

x/tools/gopls: incorrect active parameter in signature help #37271

kliko9 opened this issue Feb 17, 2020 · 3 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.4.0

Comments

@kliko9
Copy link

kliko9 commented Feb 17, 2020

What version of Go are you using (go version)?

gopls version 0.3.0 - 0.3.2
go version go1.13.5 linux/amd64
coc.nvim version: 0.0.74-bc017b02e6

Does this issue reproduce with the latest release?

yes

What did you expect to see?

Properly underlined active function parameter in documentation window on function argument typing.

What did you see instead?

The underline doesn't change even on further parameters typing. The problem appears since commit:
ab09473
(one commit before works perfectly fine)
@gopherbot gopherbot added this to the Unreleased milestone Feb 17, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 17, 2020
@gopherbot
Copy link

Thank you for filing a gopls issue! Please take a look at the Troubleshooting guide, and make sure that you have provided all of the relevant information here.

@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.4.0 Feb 18, 2020
@stamblerre stamblerre changed the title x/tools/gopls: coc nvim active function parameter x/tools/gopls: incorrect active parameter in signature help Feb 18, 2020
@stamblerre stamblerre added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 26, 2020
@gopherbot
Copy link

Change https://golang.org/cl/221817 mentions this issue: internal/lsp: fix active param in signature help

@kliko9
Copy link
Author

kliko9 commented Mar 3, 2020

https://golang.org/cl/221817 fixes the problem (at least in coc.nvim)

@golang golang locked and limited conversation to collaborators Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.4.0
Development

No branches or pull requests
3 participants
@stamblerre @gopherbot @kliko9