Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/mod/zip: TestVCS is failing on linux-amd64-longtest and linux-386-longtest sometimes #37182

Closed
dmitshur opened this issue Feb 12, 2020 · 4 comments
Closed

x/mod/zip: TestVCS is failing on linux-amd64-longtest and linux-386-longtest sometimes #37182

dmitshur opened this issue Feb 12, 2020 · 4 comments
Labels
FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

Spotted at https://build.golang.org/?repo=golang.org%2fx%2fmod on the longtest builders.

--- FAIL: TestVCS (0.00s)
    --- FAIL: TestVCS/rsc.io_quote@v1.5.1 (31.75s)
        zip_test.go:944: fetch -f --depth=1 origin refs/tags/v1.5.1:refs/tags/v1.5.1: exit status 128
    --- FAIL: TestVCS/rsc.io_quote_v3@v3.0.0 (31.75s)
        zip_test.go:944: fetch -f --depth=1 origin refs/tags/v3.0.0:refs/tags/v3.0.0: exit status 128
    --- FAIL: TestVCS/rsc.io_quote@v1.1.0 (31.79s)
        zip_test.go:944: fetch -f --depth=1 origin refs/tags/v1.1.0:refs/tags/v1.1.0: exit status 128
FAIL
FAIL	golang.org/x/mod/zip	37.982s

I can't reproduce locally on macOS right now. Unsure if it was a temporary problem, Linux-specific, or if something about the builders is different. Needs investigation.

/cc @matloob @jayconrod @bcmills
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 12, 2020
@gopherbot gopherbot added this to the Unreleased milestone Feb 12, 2020
@jayconrod
Copy link
Contributor

Thanks for reporting. I'll take a look.

This looks like a failure running git fetch, so it's likely a network or upstream issue. If that's the case, there may not be anything to do. It's important that the test covers fetching from real repositories, but unfortunately that implies a bit of flakiness.

@jayconrod jayconrod self-assigned this Feb 12, 2020
@bcmills
Copy link
Contributor

bcmills commented Feb 12, 2020

#35515 might make it easier to spot a pattern and figure out whether the issue is upstream or in the test. (At the moment, fetchlogs is not very useful for the x/ repos.)

@jayconrod
Copy link
Contributor

Can't reproduce. Pretty sure it's a network or upstream flake though.

The answer here is probably to pack up the repo in testdata, then do some git config magic so a fetch in another repository goes there. Only on the builders.

@jayconrod
Copy link
Contributor

This should have been fixed by CL 228397. Not seeing any failures since then.

@golang golang locked and limited conversation to collaborators May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@jayconrod @dmitshur @bcmills @gopherbot