New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: Load concurrency error reported to LSP client #37164
Comments
@heschik: I'll leave it up to you to decide what you want to log here. It seems fine to me to log an error, so I'm not sure that this requires a change. |
I would be happy to make it a warning but we don't have those yet. |
My understanding of an error being logged from server to client is that the client/user should do something with that error, i.e. investigate/report it. Hence why I'm pushing to try and eliminate all errors that are not actually errors, as well as having generic assertions in tests that verify we haven't seen any errors in the course of normal behaviour. However, if this understanding is wrong, please correct me!
Is If it can, then I don't think this should be reported as an error. If it can't, what are we expecting the client/user to do with the error? cc @findleyr given discussions about |
I'm not sure that I agree. To me, there is a distinction between a logged message (
If I'm going to go ahead and close this issue. Please re-open if you have further thoughts, but I don't think it's incorrect for us to log the error here. |
What I would expect, and I could be totally wrong, is that a log message that tells me:
Is, at most, a warning. As opposite to:
That is an error. The I'm not saying that we should re-open the issue, just wanted to share my thoughts. |
I agree that this particular error message could probably be a warning. I've updated #36880 to reflect that we should support warnings in logs. I just want to discourage relying on the contents of |
golang.org/issues/37164 has now been closed and the outstanding issues described in: golang/go#37164 (comment) have been transferred to golang.org/issues/36880. Update the skip for the scenario_bugs/bug_gopls_37164 test to reference golang.org/issues/36880 therefore.
) golang.org/issues/37164 has now been closed and the outstanding issues described in: golang/go#37164 (comment) have been transferred to golang.org/issues/36880. Update the skip for the scenario_bugs/bug_gopls_37164 test to reference golang.org/issues/36880 therefore.
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
This is a follow up to #36772 (comment)
In #36772 we encountered a number of errors, one of which was caused by two runs of
cmd/go
resulting in racey reads/writes togo.mod
.This is a followup issue to record a further error we are seeing be reported:
gopls
log file: gopls.logWhat did you expect to see?
No error level log message;
gopls
did not fail here.What did you see instead?
Per above.
cc @stamblerre @heschik
FYI @leitzler
The text was updated successfully, but these errors were encountered: