Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: README images should be proxied to protect user privacy #37128

Open
ghost opened this issue Feb 7, 2020 · 1 comment
Open

x/pkgsite: README images should be proxied to protect user privacy #37128

ghost opened this issue Feb 7, 2020 · 1 comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Milestone
pkgsite/frontend

Comments

@ghost
Copy link

ghost commented Feb 7, 2020 •
edited by ghost

The overview page links directly to images referenced from the readme markdown. These references allow third parties to track users on pkg.go.dev.

Github proxies images referenced from the readme to prevent such tracking. See the following for more information:

pkg.go.dev should do the same.

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/labstack/echo?tab=overview and many other ?tab=overview pages.

What did you do?

I visited the page.

What did you expect to see?

I expected to see requests to pkg.go.dev and it's trusted partners.

What did you see instead?

I saw image requests to sourcegraph.com, img.sheilds.go and goreportcard.com.
@gopherbot gopherbot added this to the Unreleased milestone Feb 7, 2020
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 14, 2020
@dmitshur
Copy link
Contributor

/cc @julieqiu per owners.

@julieqiu julieqiu changed the title go.dev: proxy images referenced from overview tab to protect user privacy go.dev: README images should be proxied to protect user privacy Feb 19, 2020
@julieqiu julieqiu changed the title go.dev: README images should be proxied to protect user privacy x/pkgsite: README images should be proxied to protect user privacy Jun 15, 2020
@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/frontend Aug 27, 2020
@julieqiu julieqiu removed the website label Sep 22, 2020
@julieqiu julieqiu mentioned this issue Dec 10, 2020
Closed
@julieqiu julieqiu removed the website label Dec 10, 2020
@hyangah hyangah added the pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development label May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/frontend Issues related to pkgsite HTML/CSS/JavaScript and frontend development pkgsite
Projects
None yet
Milestone
pkgsite/frontend
Development

No branches or pull requests
4 participants
@dmitshur @hyangah @julieqiu @gopherbot