Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.dev: consider making header non-sticky #37110

Closed
dmage opened this issue Feb 7, 2020 · 11 comments
Closed

go.dev: consider making header non-sticky #37110

dmage opened this issue Feb 7, 2020 · 11 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite UX Issues that involve UXD/UXR input
Milestone

Comments

@dmage
Copy link
Contributor

dmage commented Feb 7, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/k8s.io/klog?tab=doc or any other package.

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.130 Safari/537.36

Screenshot

Screenshot 2020-02-07 at 16 49 19

What did you expect to see?

I'd expect my screen space to be used efficiently.

What did you see instead?

A quite big header.

@gopherbot gopherbot added this to the Unreleased milestone Feb 7, 2020
@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 7, 2020
@cagedmantis
Copy link
Contributor

/cc @julieqiu

@arp242
Copy link

arp242 commented Feb 21, 2020

I've been using this userstyle to remove it, FYI:

.Site-header { position: static; }  /* Unfix banner */
:target::before { display: none; }  /* Undo fixing of scroll position with fixed header */

@julieqiu
Copy link
Member

julieqiu commented Feb 28, 2020

Thanks for the feedback!

We're currently discussing this request with our UX team, along with other design feedback we've received for the site. We want to review design feedback we have received as part of a broader redesign, as opposed to make piecemeal decisions. I'll update this issue once we have decided on any changes.

/cc @spf13 @fflewddur @pearring

@julieqiu julieqiu added the UX Issues that involve UXD/UXR input label Feb 28, 2020
@tooolbox
Copy link

If anything, this is probably the most important nav you would want to keep around:

pkg go dev subnav

@mholt
Copy link

mholt commented Jun 15, 2020

I'm in favor of un-stickying it.

Specifically, the least likely thing I am to do after scrolling deep into a package's docs is to look up another package or access the menu. I also agree that if something is stickied on that page, it should be the tabs, and a very thin (~1.5em height) sticky at that.

@narqo
Copy link
Contributor

narqo commented Jun 17, 2020

Following the tweet I wrote last winter, I wanted to 👍 to the issue.

I have a strong belief, sticky headers shouldn't be used on the read-heavy sites.

As it's now pkg.go.dev team has added one extra bar to the site's header (i.e. "Support the Equal Justice Initiative"). I'm ok with the bar being there, but I wanted to point out, that in the way how it's implemented, it hurts the UX of the site.

Screenshot 2020-06-17 at 09 14 54

(the comparison of heights, "useful" content vs headers, on 13" MBP, I use daily for work)

@arp242
Copy link

arp242 commented Jun 17, 2020

Additional point which hasn't been raised: my laptop's screen is 1366x768, the usable screen size (without Firefox's UI chrome) is 675px, and the banner is 105px. This means that the banner takes up 15% of my screen size with the default zoom level (more if I zoom in!), which is not an insignificant amount on an already small screen.

The issue is less pronounced with a larger resolution, but I think it would be a good thing to ensure the Go documentation is as accessible as we can make it, including for people of limited financial means (possibly from a disadvantaged background and/or parts of the world where most of the population is of limited financial means) who use comparatively "outdated" hardware.

In other words, I think it's a little bit more than "just an UX issue". Ironically, putting the BLM banner there actually made the site harder to use especially for people from a lower economical class (which are disproportionally black in the US) wanting to learn/use Go, which I'm pretty sure wasn't the intention with that.

@gopherbot
Copy link

Change https://golang.org/cl/245400 mentions this issue: content/static,devtools,internal: update header to spec

@arp242
Copy link

arp242 commented Jul 30, 2020

Note the new banner sits over the scrollbar now:

screenshot_2020-07-31-04-44-49_border

Also, after clicking on an item in the header it seems the focus is "stuck" somewhere and can no longer use page up, home, arrow down, or other navigation keys.

Both of this happens in both Firefox and Chromium; I didn't test other browsers.

It also doesn't address the issue really: it's still a fixed banner taking up screen space better used for actually reading the documentation. Arguably it's even worse because it's now a distracting animated thing (never mind the bugs). I don't get what's the problem with a simple static web page with text 🤷‍♂️

FYI @andybons @julieqiu

At any rate, here's a new userstyle to disable all of this again, for whom it may concern:

.DetailsNavFixed { display: none; }   /* Unfix banner */
:target::before { display: none;; }   /* Undo hack to fix scroll position with fixed header */

@tooolbox
Copy link

tooolbox commented Aug 1, 2020

I do think it's a more useful menu than the original (which is what I said in my comment).

However, from playing with it and using it, I think that having the screen real estate for viewing the docs is more valuable to me than having the navigation always available.

As much as it must be annoying to thrash around on this single point, could we try no sticky banner at all and see how that goes? No matter the answer, I really appreciate the Go Team's attention on this seemingly simple matter :)

@shabbyrobe
Copy link

Should this be closed? There's still a big sticky header, now with a distracting animation. I too would prefer the screen area be left clear for reading and reading alone. None of the information stuck in the header is useful to me below the fold while I'm trying to read through package documentation.

@golang golang locked and limited conversation to collaborators Jul 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite UX Issues that involve UXD/UXR input
Projects
None yet
Development

No branches or pull requests

9 participants